Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQ-JMSRA pooled connection validation broken #3218

Closed
svendiedrichsen opened this issue Oct 1, 2018 · 3 comments
Closed

MQ-JMSRA pooled connection validation broken #3218

svendiedrichsen opened this issue Oct 1, 2018 · 3 comments
Assignees
Labels
Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back

Comments

@svendiedrichsen
Copy link
Contributor

svendiedrichsen commented Oct 1, 2018

Description


I have filed a bug with OpenMQ that the MQ-JMSRA connectors com.sun.messaging.jms.ra.ManagedConnectionFactory does not implement javax.resource.spi.ValidatingManagedConnectionFactory. This leads to pooled connections which are deemed to be valid when they may be not. The connectors-runtime com.sun.enterprise.resource.allocator.AbstractConnectorAllocator method shows the problem:

    public Set getInvalidConnections(Set connectionSet)
            throws ResourceException {
        if (mcf instanceof ValidatingManagedConnectionFactory) {
            return ((ValidatingManagedConnectionFactory) this.mcf).
                    getInvalidConnections(connectionSet);
        }
        return null;
    }

In case of a JMS Server restart this leads to broken connection pooled which in our case mainly hinders the JMS cache synchronization which slowly breaks application functionality.

OpenMQ-Bug: eclipse-ee4j/openmq#422

You might want to work around this.

Expected Outcome

Pooled JMS connections are validated.

Current Outcome

Broken connections are kept in pool unless used.

Steps to reproduce (Only for bug reports)

Restart an external JMS server and watch the logs when i.e. producing eclipselink cache sync messages.

Environment

  • Payara Version: 4.x/5.x
  • Edition: any that uses OpenMQ MQ-JMSRA
  • JDK Version: doesn't matter
  • Operating System: doesn't matter
  • Database: doesn't matter
@svendiedrichsen svendiedrichsen changed the title MQ-JMSRA connection pooling broken MQ-JMSRA pooled connection validation broken Oct 1, 2018
@fturizo fturizo self-assigned this Feb 6, 2020
@fturizo
Copy link
Contributor

fturizo commented Feb 6, 2020

@svendiedrichsen is this issue still present in the current release of Payara Server 5.x? Are you able to provide a reproducer with the correct instructions to encounter the problem?

@fturizo
Copy link
Contributor

fturizo commented Feb 26, 2020

@svendiedrichsen, have you verified that the issue is still present in the current release of Payara Server 5.x? If we do not receive any updates soon we'll close this issue.

@fturizo fturizo added the Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back label Feb 26, 2020
@svendiedrichsen
Copy link
Contributor Author

Yes, please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back
Projects
None yet
Development

No branches or pull requests

3 participants