Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1683 Make asadmin commands for environment warning bar optiona… #1769

Conversation

Projects
None yet
8 participants
@michaelranaldo
Copy link
Contributor

commented Jul 17, 2017

…l, and change default colour to red

@michaelranaldo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2017

Jenkins test please

@michaelranaldo michaelranaldo requested a review from Pandrex247 Jul 17, 2017

@@ -59,7 +59,7 @@
String getMessage();
public void setMessage(String message);

@Attribute(required = false, defaultValue = "#325764")
@Attribute(required = false, defaultValue = "#ff0000")

This comment has been minimized.

Copy link
@mikecroft

mikecroft Jul 17, 2017

Contributor

Very minor point here, but could we have a "nice" red colour? E.g. the Bootstrap red shade is #D9534F

This comment has been minimized.

Copy link
@mikecroft

mikecroft Jul 17, 2017

Contributor

Particularly since the foreground colour is #FFFFFF, the bootstrap red works well and is quite readable :)

This comment has been minimized.

Copy link
@michaelranaldo

michaelranaldo Jul 17, 2017

Author Contributor

Okey dokes

@smillidge
Copy link
Contributor

left a comment

Please try to avoid white space changes as they just mess up the diff.

@payara-ci

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

One or more tests have failed

@michaelranaldo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2017

Jenkins test please

@payara-ci

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2017

All tests have passed

@michaelranaldo michaelranaldo requested a review from Cousjava Jul 17, 2017

@Cousjava
Copy link
Member

left a comment

Tested and works

@michaelranaldo michaelranaldo added this to the Payara 173 milestone Jul 18, 2017

Merge branch 'master' of https://github.com/payara/payara into PAYARA…
…-1683-make-parameters-of-the-set-environment-warning-configuration-asadmin-command-optional
@michaelranaldo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2017

Jenkins test please

@payara payara deleted a comment from payara-ci Jul 20, 2017

@payara payara deleted a comment from payara-ci Jul 20, 2017

@payara payara deleted a comment from payara-ci Jul 20, 2017

@payara payara deleted a comment from payara-ci Jul 20, 2017

@payara-ci

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2017

Quick build and test passed!

@smillidge smillidge merged commit 315c6b4 into payara:master Jul 24, 2017

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

@fturizo fturizo removed the 4:Ready label Jul 24, 2017

MattGill98 added a commit to MattGill98/Payara that referenced this pull request Aug 17, 2017

PAYARA-1683 Make asadmin commands for environment warning bar optiona… (
payara#1769)

* PAYARA-1683 Make asadmin commands for environment warning bar optional, and change default colour to red

* PAYARA-1683 A friendlier shade of red

* PAYARA-1683 Updated Strings.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.