Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1269-Upgrade-libpam4j-to-v1.8-with-groupid-org-kohsuke #1951

Conversation

Projects
None yet
5 participants
@mulderbaba
Copy link
Member

mulderbaba commented Sep 8, 2017

No description provided.

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Sep 8, 2017

jenkins test please

@mulderbaba mulderbaba added this to the Payara 174 milestone Sep 8, 2017

@mulderbaba mulderbaba self-assigned this Sep 8, 2017

@mulderbaba mulderbaba requested a review from smillidge Sep 8, 2017

@payara-ci

This comment has been minimized.

Copy link
Contributor

payara-ci commented Sep 8, 2017

Quick build and test passed!

@smillidge

This comment has been minimized.

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Sep 8, 2017

no @smillidge. I used that class for the realm config.

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Sep 8, 2017

So the classnames are still org.jvnet?

@mulderbaba

This comment has been minimized.

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Sep 8, 2017

Doesn't it need an upgraded JNA?

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Sep 8, 2017

upgraded jna comes with the libpam4j as a transitive dependency. our version of jna is now 4.0.0. I'm planning to update it as well, after forking libpam4j and sending a PR. if that doesn't get accepted in a timely manner we can host it in patched projects repo.

@lprimak

lprimak approved these changes Sep 8, 2017

@smillidge smillidge merged commit 34b8f03 into payara:master Sep 10, 2017

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

michaelranaldo added a commit to michaelranaldo/Payara that referenced this pull request Sep 12, 2017

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Oct 6, 2017

@mulderbaba mulderbaba deleted the mulderbaba:PAYARA-1269-Upgrade-libpam4j-to-v1.8-with-groupid-org-kohsuke branch Oct 29, 2017

mulderbaba added a commit to mulderbaba/Payara that referenced this pull request Nov 1, 2017

mulderbaba added a commit to mulderbaba/Payara that referenced this pull request Nov 2, 2017

mulderbaba added a commit to mulderbaba/Payara that referenced this pull request Nov 10, 2017

mulderbaba added a commit to mulderbaba/Payara that referenced this pull request Nov 10, 2017

mulderbaba added a commit to mulderbaba/Payara that referenced this pull request Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.