New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2848 catch ConcurrentModificationException #2840

Merged
merged 3 commits into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@svendiedrichsen
Contributor

svendiedrichsen commented Jun 13, 2018

Fixes #2833

@smillidge smillidge added the CLA label Jun 13, 2018

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Jun 13, 2018

Contributor

Jenkins test please

Contributor

smillidge commented Jun 13, 2018

Jenkins test please

@svendiedrichsen

This comment has been minimized.

Show comment
Hide comment
@svendiedrichsen

svendiedrichsen Jun 13, 2018

Contributor

@smillidge I'm trying to put this functionality somewhere but I don't know where. This code to close cached JarFiles exists 3 times in the codebase and I would like to extract it and fix it for all of them.

Modules:

  • weld-integration
  • hazelcast-bootstrap
  • deployment-admin
Contributor

svendiedrichsen commented Jun 13, 2018

@smillidge I'm trying to put this functionality somewhere but I don't know where. This code to close cached JarFiles exists 3 times in the codebase and I would like to extract it and fix it for all of them.

Modules:

  • weld-integration
  • hazelcast-bootstrap
  • deployment-admin
@svendiedrichsen

This comment has been minimized.

Show comment
Hide comment
@svendiedrichsen

svendiedrichsen Jun 13, 2018

Contributor

@smillidge And also there is a chance of avoiding the ConcurrentModificationException by synchronizing against the cached JarFileFactory instance. This allows to fully iterate and close all JarFiles.

Contributor

svendiedrichsen commented Jun 13, 2018

@smillidge And also there is a chance of avoiding the ConcurrentModificationException by synchronizing against the cached JarFileFactory instance. This allows to fully iterate and close all JarFiles.

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 13, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 13, 2018

Quick build and test passed!

extracted code to close cached JarFiles into utils class in admin-uti…
…l. Using utils class where duplicated code has been used.
@svendiedrichsen

This comment has been minimized.

Show comment
Hide comment
@svendiedrichsen

svendiedrichsen Jun 13, 2018

Contributor

Jenkins test please

Contributor

svendiedrichsen commented Jun 13, 2018

Jenkins test please

@smillidge

Thanks for the PR looks good apart from the missing copyright header. Location of the JarFileUtils is good.

@@ -0,0 +1,63 @@
package com.sun.enterprise.admin.util;

This comment has been minimized.

@smillidge

smillidge Jun 14, 2018

Contributor

This file needs the Payara copyright header

@smillidge

smillidge Jun 14, 2018

Contributor

This file needs the Payara copyright header

This comment has been minimized.

@svendiedrichsen

svendiedrichsen Jun 14, 2018

Contributor

Sure. I'll fix this. I wasn't sure about the package though.

@svendiedrichsen

svendiedrichsen Jun 14, 2018

Contributor

Sure. I'll fix this. I wasn't sure about the package though.

@smillidge smillidge changed the title from PAYARA-2833 catch ConcurrentModificationException to PAYARA-2848 catch ConcurrentModificationException Jun 14, 2018

@smillidge smillidge added this to the Payara 5.183 milestone Jun 14, 2018

@svendiedrichsen

This comment has been minimized.

Show comment
Hide comment
@svendiedrichsen
Contributor

svendiedrichsen commented Jun 14, 2018

@smillidge Done.

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Jun 14, 2018

Contributor

thanks

Contributor

smillidge commented Jun 14, 2018

thanks

@smillidge

This comment has been minimized.

Show comment
Hide comment
@smillidge

smillidge Jun 14, 2018

Contributor

jenkins test please

Contributor

smillidge commented Jun 14, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 14, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 14, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 06d87ea into payara:master Jun 15, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

@svendiedrichsen svendiedrichsen deleted the svendiedrichsen:2833_CONCURRENT_MODIFICATION branch Jun 15, 2018

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jun 18, 2018

Merge pull request payara#2840 from svendiedrichsen/2833_CONCURRENT_M…
…ODIFICATION

PAYARA-2848 catch ConcurrentModificationException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment