New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-2848 catch ConcurrentModificationException #2840
Merged
Pandrex247
merged 3 commits into
payara:master
from
svendiedrichsen:2833_CONCURRENT_MODIFICATION
Jun 15, 2018
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
nucleus/admin/util/src/main/java/com/sun/enterprise/admin/util/JarFileUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| package com.sun.enterprise.admin.util; | ||
|
|
||
| import java.io.IOException; | ||
| import java.lang.reflect.Field; | ||
| import java.net.URL; | ||
| import java.util.ConcurrentModificationException; | ||
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.jar.JarFile; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
|
|
||
| /** | ||
| * Utilities class for JarFiles | ||
| * | ||
| * @author Sven Diedrichsen | ||
| * @since 13.06.18 | ||
| */ | ||
| public class JarFileUtils { | ||
|
|
||
| private static final Logger LOG = Logger.getLogger(JarFileUtils.class.getName()); | ||
|
|
||
| /** | ||
| * Ensures that all cached JarFile instances are closed. | ||
| */ | ||
| public static void closeCachedJarFiles() { | ||
| try { | ||
| Map<String, JarFile> files = null; | ||
| Object jarFileFactoryInstance = null; | ||
| Class clazz = Class.forName("sun.net.www.protocol.jar.JarFileFactory", true, URL.class.getClassLoader()); | ||
| Field fields[] = clazz.getDeclaredFields(); | ||
| for (Field field : fields) { | ||
| if ("fileCache".equals(field.getName())) { | ||
| field.setAccessible(true); | ||
| files = (Map<String, JarFile>) field.get(null); | ||
| } | ||
| if ("instance".equals(field.getName())) { | ||
| field.setAccessible(true); | ||
| jarFileFactoryInstance = field.get(null); | ||
| } | ||
| } | ||
| if (files != null && !files.isEmpty()) { | ||
| Set<JarFile> jarFiles = new HashSet<>(); | ||
| if(jarFileFactoryInstance != null) { | ||
| synchronized (jarFileFactoryInstance) { | ||
| jarFiles.addAll(files.values()); | ||
| } | ||
| } else { | ||
| jarFiles.addAll(files.values()); | ||
| } | ||
| for (JarFile file : jarFiles) { | ||
| if (file != null) { | ||
| file.close(); | ||
| } | ||
| } | ||
| } | ||
| } catch (ClassNotFoundException | IllegalAccessException | SecurityException | IllegalArgumentException | IOException | ConcurrentModificationException ex) { | ||
| LOG.log(Level.SEVERE, null, ex); | ||
| } | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs the Payara copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll fix this. I wasn't sure about the package though.