New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2827 Add empty java config to prevent null pointer #2847

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@Pandrex247
Contributor

Pandrex247 commented Jun 15, 2018

No description provided.

@Pandrex247 Pandrex247 added this to the Payara 5.183 milestone Jun 15, 2018

@Pandrex247 Pandrex247 requested a review from MattGill98 Jun 15, 2018

@MattGill98

Looks good to me. Do we get the same problem in embedded?

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Jun 18, 2018

Contributor

Embedded uses a different domain.xml, and that already has some entries in.

Contributor

Pandrex247 commented Jun 18, 2018

Embedded uses a different domain.xml, and that already has some entries in.

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Jun 18, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Jun 18, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 18, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 18, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 2038ed3 into payara:master Jun 18, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

@Pandrex247 Pandrex247 deleted the Pandrex247:PAYARA-2827-NullPointer-when-editing-jvm-options branch Jun 18, 2018

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jun 18, 2018

Merge pull request payara#2847 from Pandrex247/PAYARA-2827-NullPointe…
…r-when-editing-jvm-options

PAYARA-2827 Add empty java config to prevent null pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment