New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2560 Redesign set-monitoring-configuration asadmin command #2888

Merged
merged 15 commits into from Jun 29, 2018

Conversation

Projects
None yet
5 participants
@MeroRai
Contributor

MeroRai commented Jun 22, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Jun 22, 2018

@MeroRai MeroRai added this to the Payara 5.183 milestone Jun 22, 2018

@MeroRai MeroRai self-assigned this Jun 22, 2018

@OndrejM

I see 2 new set commands and 2 get commands, while the command set-monitoring-configuration (and get...) is deprecated. Looks good to me

Show outdated Hide outdated ...ice/src/main/java/fish/payara/jmx/monitoring/JMXMonitoringFormatter.java Outdated
*
* @author savage
*/
@Service(name = "get-jmx-monitoring-configuration")

This comment has been minimized.

@OndrejM

OndrejM Jun 22, 2018

Contributor

Note to myself - needs documenting

@OndrejM

OndrejM Jun 22, 2018

Contributor

Note to myself - needs documenting

@RestEndpoints({
@RestEndpoint(configBean = Domain.class,
opType = RestEndpoint.OpType.POST,
path = "set-monitoring-service-configuration",

This comment has been minimized.

@OndrejM

OndrejM Jun 22, 2018

Contributor

Note to myself: Also this and the get command need documentation

@OndrejM

OndrejM Jun 22, 2018

Contributor

Note to myself: Also this and the get command need documentation

@OndrejM

This comment has been minimized.

Show comment
Hide comment
@OndrejM

OndrejM Jun 22, 2018

Contributor

Please also ensure that set-monitoring-service-configuration --enabled=true is applied dynamicaly, in the same way as set configs.config.server-config.monitoring-service.monitoring-enabled=true. Also set-monitoring-service-configuration --amxenabled=true should start AMX dynamically same as set configs.config.server-config.amx-configuration.enabled=true (dynamic stop isn't supported). And the same with --mbeansEnabled=true

Contributor

OndrejM commented Jun 22, 2018

Please also ensure that set-monitoring-service-configuration --enabled=true is applied dynamicaly, in the same way as set configs.config.server-config.monitoring-service.monitoring-enabled=true. Also set-monitoring-service-configuration --amxenabled=true should start AMX dynamically same as set configs.config.server-config.amx-configuration.enabled=true (dynamic stop isn't supported). And the same with --mbeansEnabled=true

@MeroRai MeroRai changed the title from PYARA-2560 Redesign set-monitoring-configuration asadmin command to PAYARA-2560 Redesign set-monitoring-configuration asadmin command Jun 22, 2018

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Jun 22, 2018

Contributor

@OndrejM all the commands you mentioned above does apply dynamically.

Contributor

MeroRai commented Jun 22, 2018

@OndrejM all the commands you mentioned above does apply dynamically.

@MeroRai MeroRai removed the MERGE CONFLICT label Jun 27, 2018

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Jun 27, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Jun 27, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 27, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 27, 2018

Quick build and test passed!

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Jun 28, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Jun 28, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jun 28, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jun 28, 2018

Quick build and test passed!

@lprimak lprimak merged commit fb780ca into payara:master Jun 29, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment