New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2889 Defer OpenAPI Scanning Until Endpoint Visit #2916

Merged
merged 6 commits into from Jul 5, 2018

Conversation

Projects
None yet
4 participants
@MattGill98
Contributor

MattGill98 commented Jul 2, 2018

  • Deferred OpenAPI scanning until the /openapi endpoint is visited.
  • Allowed document creation for apps deployed while the OpenAPI service is disabled, since it's now created on endpoint visiting.
  • Added a null check to prevent potential @Produces errors.

@MattGill98 MattGill98 added this to the Payara 5.183 milestone Jul 2, 2018

@MattGill98 MattGill98 self-assigned this Jul 2, 2018

@MattGill98 MattGill98 requested a review from MeroRai Jul 2, 2018

@MattGill98

This comment has been minimized.

Show comment
Hide comment
@MattGill98

MattGill98 Jul 2, 2018

Contributor

jenkins test please

Contributor

MattGill98 commented Jul 2, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 2, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 2, 2018

Quick build and test passed!

@MattGill98

This comment has been minimized.

Show comment
Hide comment
@MattGill98

MattGill98 Jul 2, 2018

Contributor

jenkins test please

Contributor

MattGill98 commented Jul 2, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 2, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 2, 2018

Quick build and test passed!

@MeroRai

MeroRai approved these changes Jul 3, 2018

@OndrejM

This comment has been minimized.

Show comment
Hide comment
@OndrejM

OndrejM Jul 4, 2018

Contributor

Hi @MattGill98 the current solution is thread-safe and I'll approve.

Contributor

OndrejM commented Jul 4, 2018

Hi @MattGill98 the current solution is thread-safe and I'll approve.

@OndrejM

OndrejM approved these changes Jul 4, 2018

@MattGill98

This comment has been minimized.

Show comment
Hide comment
@MattGill98

MattGill98 Jul 4, 2018

Contributor

jenkins test please

Contributor

MattGill98 commented Jul 4, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 4, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 4, 2018

Quick build and test passed!

@MattGill98 MattGill98 merged commit 9bf2423 into payara:master Jul 5, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

MattGill98 added a commit to MattGill98/Payara that referenced this pull request Jul 6, 2018

Merge pull request payara#2916 from MattGill98/PAYARA-2889-Defer-Open…
…API-Scanning-Until-Endpoint-Visit

PAYARA-2889 Defer OpenAPI Scanning Until Endpoint Visit

Cousjava added a commit that referenced this pull request Jul 9, 2018

PAYARA-2889 Defer OpenAPI Scanning Until Endpoint Visit PAYARA4 (#2939)
* Merge pull request #2916 from MattGill98/PAYARA-2889-Defer-OpenAPI-Scanning-Until-Endpoint-Visit

PAYARA-2889 Defer OpenAPI Scanning Until Endpoint Visit

* Removed PayaraExecutorService reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment