New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2871 Improve listing batch jobs memory usage in admin console #2965

Merged
merged 17 commits into from Jul 23, 2018

Conversation

Projects
None yet
5 participants
@MeroRai
Contributor

MeroRai commented Jul 17, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Jul 17, 2018

@MeroRai MeroRai added this to the Payara 5.183 milestone Jul 17, 2018

@MeroRai MeroRai self-assigned this Jul 17, 2018

@MeroRai MeroRai requested a review from MattGill98 Jul 18, 2018

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Jul 18, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Jul 18, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 18, 2018

Contributor

Quick build and test failed!

Contributor

payara-ci commented Jul 18, 2018

Quick build and test failed!

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Jul 18, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Jul 18, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 18, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 18, 2018

Quick build and test passed!

@MattGill98

Looks overall very good! Just one or two things that need addressing.

Show outdated Hide outdated ...full/src/main/java/fish/payara/full/admingui/handlers/BatchHandlers.java Outdated
*/
<f:verbatim>
<script type="text/javascript">

This comment has been minimized.

@MattGill98

MattGill98 Jul 19, 2018

Contributor

This is an unusual way of adding CSS. Usually this would be done by using CSS selectors carefully, is this not possible here?

@MattGill98

MattGill98 Jul 19, 2018

Contributor

This is an unusual way of adding CSS. Usually this would be done by using CSS selectors carefully, is this not possible here?

This comment has been minimized.

@MeroRai

MeroRai Jul 20, 2018

Contributor

I have looked at different ways to do it, but IMO this is the cleanest way and makes it easily maintainable too.

@MeroRai

MeroRai Jul 20, 2018

Contributor

I have looked at different ways to do it, but IMO this is the cleanest way and makes it easily maintainable too.

Show outdated Hide outdated ...batch-commands/src/main/java/org/glassfish/batch/ListBatchJobsProxy.java Outdated
@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Jul 23, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Jul 23, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 23, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 23, 2018

Quick build and test passed!

@MattGill98 MattGill98 merged commit 8d19168 into payara:master Jul 23, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
@ggam

This comment has been minimized.

Show comment
Hide comment
@ggam

ggam Jul 23, 2018

Typo: greater

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Aug 10, 2018

Contributor

@ggam Thanks for letting me know

Contributor

MeroRai replied Aug 10, 2018

@ggam Thanks for letting me know

MeroRai added a commit to MeroRai/Payara that referenced this pull request Aug 20, 2018

Merge pull request payara#2965 from MeroRai/PAYARA-2871
PAYARA-2871 Improve listing batch jobs memory usage in admin console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment