New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1714 Added command to generate bash autocomplete #2985

Merged
merged 3 commits into from Aug 6, 2018

Conversation

Projects
None yet
4 participants
@Cousjava
Member

Cousjava commented Jul 24, 2018

This creates a file that when run adds glassfish/bin to the path and creates autocompletion of asadmin commands

@Cousjava Cousjava added this to the Payara 5.183 milestone Jul 24, 2018

@Cousjava

This comment has been minimized.

Show comment
Hide comment
@Cousjava

Cousjava Jul 24, 2018

Member

Jenkins test please

Member

Cousjava commented Jul 24, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 24, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 24, 2018

Quick build and test passed!

@MattGill98

Why isn't this an internal command ran as part of domain creation?

@Cousjava

This comment has been minimized.

Show comment
Hide comment
@Cousjava

Cousjava Aug 1, 2018

Member

@MattGill98 Because this command requires the server to be running

Member

Cousjava commented Aug 1, 2018

@MattGill98 Because this command requires the server to be running

@Pandrex247 Pandrex247 changed the title from PAYARA-1714 Added command to generate bash autocomple to PAYARA-1714 Added command to generate bash autocomplete Aug 6, 2018

@Pandrex247 Pandrex247 merged commit 84ce032 into payara:master Aug 6, 2018

3 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

Cousjava added a commit to Cousjava/Payara that referenced this pull request Aug 7, 2018

Merge pull request payara#2985 from Cousjava/PAYARA-635-asadmin-autoc…
…omplete

PAYARA-1714 Added command to generate bash autocomplete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment