New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2986 Missing String ConfigProperty should cause DeploymentException PAYARA-2962 #2989

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
4 participants
@IrminAuwerda
Contributor

IrminAuwerda commented Jul 25, 2018

When the ConfigProperty is used with Injection the PayaraConfig is always called with a default value (org.eclipse.microprofile.config.configproperty.unconfigureddvalue).

The logic to notice that no property is found requires the StringConverter to throw the DeploymentException. The cast to String and return before Converters are determined prevents this.

Removed this line of code.

Fixes issue #2986.

@IrminAuwerda IrminAuwerda changed the title from #2986 Missing String ConfigProperty should cause DeploymentException to Fix for #2986 Missing String ConfigProperty should cause DeploymentException Jul 25, 2018

@mulderbaba mulderbaba added this to the Payara 5.183 milestone Jul 27, 2018

@mulderbaba

This comment has been minimized.

Show comment
Hide comment
@mulderbaba

mulderbaba Jul 27, 2018

Member

Jenkins test please

Member

mulderbaba commented Jul 27, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Jul 27, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Jul 27, 2018

Quick build and test passed!

@arjantijms arjantijms requested a review from smillidge Jul 31, 2018

@smillidge smillidge added Awaiting CLA and removed Awaiting CLA labels Aug 3, 2018

@smillidge smillidge merged commit e4661ef into payara:master Aug 3, 2018

3 of 4 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

@smillidge smillidge changed the title from Fix for #2986 Missing String ConfigProperty should cause DeploymentException to Fix for #2986 Missing String ConfigProperty should cause DeploymentException PAYARA-2962 Aug 9, 2018

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 9, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 9, 2018

Quick build and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment