New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2288 Create a MicroProfile Settings Page into the Admin Console #3011

Merged
merged 12 commits into from Aug 20, 2018

Conversation

Projects
None yet
4 participants
@MeroRai
Contributor

MeroRai commented Aug 1, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Aug 1, 2018

@MeroRai MeroRai added this to the Payara 5.183 milestone Aug 1, 2018

@MeroRai MeroRai self-assigned this Aug 1, 2018

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Aug 2, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Aug 2, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 2, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 2, 2018

Quick build and test passed!

@MattGill98

Looks really good overall, nice work! Just a few functional comments:

  • The 'config saved' message pushes the tabs down, I think it should appear below the tabs as with other pages.
  • The opentracing link always links to the request tracing in the 'server-config'. Not sure how doable it is, but should it link to the currently selected config?
  • I find the 'ordinal' page unintuitive. Would it be possible to have a table to set the ordinals for?
  • The same as above for the property table. It seems to allow adding properties, but not seeing them.

@MeroRai MeroRai added the DO NOT MERGE label Aug 7, 2018

@MeroRai MeroRai removed the DO NOT MERGE label Aug 17, 2018

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Aug 17, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Aug 17, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 17, 2018

Contributor

Quick build and test failed!

Contributor

payara-ci commented Aug 17, 2018

Quick build and test failed!

@MeroRai

This comment has been minimized.

Show comment
Hide comment
@MeroRai

MeroRai Aug 17, 2018

Contributor

Jenkins test please

Contributor

MeroRai commented Aug 17, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 17, 2018

Contributor

Quick build and test failed!

Contributor

payara-ci commented Aug 17, 2018

Quick build and test failed!

@Pandrex247

This comment has been minimized.

Show comment
Hide comment
@Pandrex247

Pandrex247 Aug 20, 2018

Contributor

Jenkins test please

Contributor

Pandrex247 commented Aug 20, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 20, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 20, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit 7c6ca34 into payara:master Aug 20, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Aug 29, 2018

Merge pull request payara#3011 from MeroRai/PAYARA-2288
PAYARA-2288 Create a MicroProfile Settings Page into the Admin Console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment