New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2920 OpenAPI has Hardcoded 8080 Port #3028

Merged
merged 2 commits into from Aug 17, 2018

Conversation

Projects
None yet
5 participants
@jGauravGupta
Contributor

jGauravGupta commented Aug 9, 2018

No description provided.

@jGauravGupta

This comment has been minimized.

Show comment
Hide comment
@jGauravGupta

jGauravGupta Aug 9, 2018

Contributor

jenkins test please

Contributor

jGauravGupta commented Aug 9, 2018

jenkins test please

@jGauravGupta jGauravGupta requested a review from MattGill98 Aug 9, 2018

@MattGill98

Looks good to me! Have you checked the TCK? My only worry is that I believe there's a check for only one base URL.

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 9, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 9, 2018

Quick build and test passed!

@mulderbaba

This comment has been minimized.

Show comment
Hide comment
@mulderbaba

mulderbaba Aug 14, 2018

Member

jenkins test please

Member

mulderbaba commented Aug 14, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Show comment
Hide comment
@payara-ci

payara-ci Aug 14, 2018

Contributor

Quick build and test passed!

Contributor

payara-ci commented Aug 14, 2018

Quick build and test passed!

@jGauravGupta

This comment has been minimized.

Show comment
Hide comment
@jGauravGupta

jGauravGupta Aug 14, 2018

Contributor

Not yet, I will check the MP TCK runner.

Contributor

jGauravGupta commented Aug 14, 2018

Not yet, I will check the MP TCK runner.

@jGauravGupta

This comment has been minimized.

Show comment
Hide comment
@jGauravGupta

jGauravGupta Aug 14, 2018

Contributor

Hi @MattGill98,

All tck passed.

Tests run: 222, Failures: 0, Errors: 0, Skipped: 0

Contributor

jGauravGupta commented Aug 14, 2018

Hi @MattGill98,

All tck passed.

Tests run: 222, Failures: 0, Errors: 0, Skipped: 0

@Pandrex247 Pandrex247 merged commit 4a325c6 into payara:master Aug 17, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment