New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3076 NPE when enabled request tracing from the console #3140

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@Cousjava
Member

Cousjava commented Sep 10, 2018

No description provided.

@Cousjava Cousjava added this to the Payara 5.184 milestone Sep 10, 2018

@Cousjava Cousjava requested a review from Pandrex247 Sep 10, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 10, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 10, 2018

Quick build and test passed!

@Pandrex247

Further testing required

//in this case nothing will be done, but log in case of other error
Logger.getLogger(JaxrsClientRequestTracingFilter.class.getName()).log(Level.FINE,
"activeScope in opentracing request tracing filter was null for {0}", responseContext);
return;

This comment has been minimized.

@Pandrex247

Pandrex247 Sep 10, 2018

Member

This is a very aggressive solution - I want to give this a bit of a hammering before merging.

This comment has been minimized.

@Pandrex247

Pandrex247 Sep 10, 2018

Member

The comment also has grammatical and formatting errors, and isn't entirely accurate (you can also get here if the OpenTracing context was somehow lost)

@Pandrex247

Tested

@Pandrex247 Pandrex247 merged commit 394db99 into payara:master Sep 12, 2018

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Oct 29, 2018

Merge pull request payara#3140 from Cousjava/PAYARA-3076-npe-requestt…
…racing-console

PAYARA-3076 NPE when enabled request tracing from the console

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Nov 8, 2018

Merge pull request payara#3140 from Cousjava/PAYARA-3076-npe-requestt…
…racing-console

PAYARA-3076 NPE when enabled request tracing from the console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment