New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2912 JBatch not working with PostgreSQL #3141

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
5 participants
@Cousjava
Member

Cousjava commented Sep 10, 2018

No description provided.

@Cousjava Cousjava added this to the Payara 5.184 milestone Sep 10, 2018

@Cousjava Cousjava requested a review from MeroRai Sep 10, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 10, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 10, 2018

Quick build and test passed!

@@ -521,8 +521,8 @@ private boolean isSimpleMode() {
String columnID = "jobinstanceid";
try (Connection connection = dataSource.getConnection()) {
try (PreparedStatement preparedStatement = connection.prepareStatement(query)) {
preparedStatement.setString(1, parameter1);
preparedStatement.setString(2, parameter2);
preparedStatement.setInt(1, Integer.parseInt(parameter1));

This comment has been minimized.

@smillidge

smillidge Sep 10, 2018

Contributor

You will need to test this change with other database servers

This comment has been minimized.

@Cousjava

Cousjava Sep 10, 2018

Member

Tested with PostgreSQL, Derby and MySQL

This comment has been minimized.

@MeroRai

MeroRai Sep 11, 2018

Contributor

I tested it with Derby

This comment has been minimized.

@Cousjava

Cousjava Sep 12, 2018

Member

Also tested with H2

This comment has been minimized.

@Pandrex247

Pandrex247 Sep 12, 2018

Member

Oracle DB is the last big'un to test against then

Tests done

@Pandrex247 Pandrex247 merged commit a47ebb6 into payara:master Sep 12, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment