New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2975 'metrics.xml' parsed and metadata re-registered on every call to '/metrics' endpoint #3142

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@jGauravGupta
Contributor

jGauravGupta commented Sep 10, 2018

No description provided.

@jGauravGupta

This comment has been minimized.

Contributor

jGauravGupta commented Sep 10, 2018

jenkins test please

@jGauravGupta jGauravGupta requested a review from Cousjava Sep 10, 2018

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 10, 2018

Quick build and test passed!

@Cousjava

This will reintroduce PAYARA-2707 as when there are multiple MBeans for a config only the first one will be added, if any more are loaded subsequently then they will be ignored.

@jGauravGupta

This comment has been minimized.

Contributor

jGauravGupta commented Sep 10, 2018

Hi @Cousjava,

The lazy loaded mbeans are now stored in unresolvedBaseMetadataList & unresolvedVendorMetadataList for further evaluation so it will not be ignored.

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 11, 2018

@jGauravGupta But they will only be resolved to one MBean, in cases where they are for multiple when it has a wildcard it will only resolve the first one. I have tested this.

@jGauravGupta

This comment has been minimized.

Contributor

jGauravGupta commented Sep 11, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 11, 2018

Quick build and test passed!

@Cousjava

Tested and now works. I have also run the MP Metrics TCK and it passes as well.

@arjantijms arjantijms merged commit ff1a04e into payara:master Sep 13, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment