New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields #3163

Merged
merged 6 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@MeroRai
Contributor

MeroRai commented Sep 13, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Sep 13, 2018

@MeroRai MeroRai added this to the Payara 5.184 milestone Sep 13, 2018

@MeroRai MeroRai self-assigned this Sep 13, 2018

@MeroRai MeroRai requested a review from MattGill98 Sep 13, 2018

for (Field field : clazz.getDeclaredFields()) {
processAnnotation(field, annotationClass, annotationFunction, altClass, altFunction,

This comment has been minimized.

@MattGill98

MattGill98 Sep 14, 2018

Member

I believe we discussed removing this? This class would be best kept generic, moving the implementation specific logic into the handleParam methods.

@Pandrex247 Pandrex247 changed the title from OpenAPI Doesn't Support @...Param Annotated Fields to PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields Sep 14, 2018

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 1, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 1, 2018

Quick build and test passed!

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 1, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 1, 2018

Quick build and test passed!

@payara payara deleted a comment from smillidge Oct 2, 2018

@MattGill98 MattGill98 merged commit 4077ca3 into payara:master Oct 2, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 3, 2018

Merge pull request payara#3163 from MeroRai/PAYARA-3085
PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 10, 2018

Merge pull request payara#3163 from MeroRai/PAYARA-3085
PAYARA-3085 OpenAPI Doesn't Support @...Param Annotated Fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment