New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3110 Made TracedInterceptor serializable #3169

Merged
merged 2 commits into from Oct 12, 2018

Conversation

Projects
None yet
7 participants
@Cousjava
Member

Cousjava commented Sep 17, 2018

This resolves a warning when persisting session scoped beans

PAYARA-3110 Made TracedInterceptor serializable
This resolves a warning when persisting session scoped beans

@Cousjava Cousjava added this to the Payara 5.184 milestone Sep 17, 2018

@Cousjava Cousjava requested a review from Pandrex247 Sep 17, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 17, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 17, 2018

Quick build and test passed!

@smillidge

How do you reinstate the Bean Manager after the bean is retrieved from the session?

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 21, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 21, 2018

Quick build and test passed!

@svendiedrichsen

This comment has been minimized.

Contributor

svendiedrichsen commented Sep 21, 2018

@Cousjava You could keep the TracedInterceptor serializable if you don't inject the BeanManager but use CDI.getBeanManager() whenever the BeanManager is needed.

@arjantijms

This comment has been minimized.

Member

arjantijms commented Oct 9, 2018

@smillidge @Cousjava @svendiedrichsen

The concern regarding the bean manager is addressed by section 6.6.3 of the CDI spec:

the built-in beans of type Instance, Event, InjectionPoint and BeanManager are passivation capable dependencies.

See https://docs.jboss.org/cdi/spec/2.0-PFD/cdi-spec.html#passivation_capable_dependency

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 9, 2018

Jenkins2 test please

Addressed

@Pandrex247 Pandrex247 merged commit be7b4e6 into payara:master Oct 12, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

Cousjava added a commit to Cousjava/Payara that referenced this pull request Oct 25, 2018

Merge pull request payara#3169 from Cousjava/PAYARA-3110-cdi-session-…
…store-error

PAYARA-3110 Made TracedInterceptor serializable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment