New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3109 OpenAPI doesn't support if schema type is array #3177

Merged
merged 3 commits into from Oct 1, 2018

Conversation

Projects
None yet
3 participants
@MeroRai
Contributor

MeroRai commented Sep 18, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Sep 18, 2018

@MeroRai MeroRai added this to the Payara 5.184 milestone Sep 18, 2018

@MeroRai MeroRai self-assigned this Sep 18, 2018

@MeroRai MeroRai requested a review from MattGill98 Sep 18, 2018

@MattGill98

Looks good to me. Do the parameter handling methods need code adding to handle collection types?

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Sep 25, 2018

Jenkins test please

@@ -283,7 +283,7 @@ public static SchemaType getSchemaType(Class<?> type) {
|| type == float.class || type == Float.class || type == double.class || type == Double.class) {
return SchemaType.NUMBER;
}
if (type.isArray()) {
if (type.isArray() || Iterable.class.isAssignableFrom(type) || Collection.class.isAssignableFrom(type)) {

This comment has been minimized.

@MattGill98

MattGill98 Sep 25, 2018

Member

That second addition is redundant, Collections are already iterable

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 25, 2018

Quick build and test passed!

@MattGill98

As long as this passes the TCK it looks good to me.

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Sep 26, 2018

Jenkins test please

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Sep 26, 2018

@MattGill98, It passes the TCK

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 26, 2018

Quick build and test passed!

@MattGill98 MattGill98 merged commit bb9e662 into payara:master Oct 1, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 3, 2018

Merge pull request payara#3177 from MeroRai/PAYARA-3109
PAYARA-3109 OpenAPI doesn't support if schema type is array

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 10, 2018

Merge pull request payara#3177 from MeroRai/PAYARA-3109
PAYARA-3109 OpenAPI doesn't support if schema type is array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment