New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3117 made deregistring non-existent thread message fine #3191

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
6 participants
@Cousjava
Member

Cousjava commented Sep 24, 2018

No description provided.

@Cousjava Cousjava added this to the Payara 5.184 milestone Sep 24, 2018

@Cousjava Cousjava requested a review from rdebusscher Sep 24, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 24, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 24, 2018

Quick build and test passed!

@rdebusscher

The message no longer appears at default log levels.

@smillidge

This comment has been minimized.

Contributor

smillidge commented Sep 24, 2018

Can you try and work out why there is a double message in the first place?

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 25, 2018

This is due to the thread being registered twice if there is a contexthandle generating a proxy, but there is no way at

to find out if the Runnable is being proxied at that point

@smillidge

This comment has been minimized.

Contributor

smillidge commented Sep 25, 2018

Have you reviewed the stack at each registration in a debugger to understand if this can be prevented for the case when there is a proxy?

@Cousjava

This comment has been minimized.

Member

Cousjava commented Sep 27, 2018

@smillidge Yes, I said in my previous comment there is no way to tell in the code at the (un)registration point if it is a proxy or not.

@Pandrex247 Pandrex247 merged commit aa42b9e into payara:master Oct 4, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment