New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3128 ensure we store and set supported protocols as well as ci… #3200

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Projects
None yet
6 participants
@smillidge
Contributor

smillidge commented Sep 25, 2018

…phers

@smillidge smillidge added this to the Payara 5.184 milestone Sep 25, 2018

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Sep 26, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Sep 26, 2018

Quick build and test passed!

@Pandrex247

Possible unused lists

@@ -152,18 +156,22 @@ public IIOPSSLSocketFactory() {
boolean securityEnabled = Boolean.valueOf(listener.getSecurityEnabled());
if (securityEnabled) {
ArrayList<String> supportedProtocol = new ArrayList<>(4);

This comment has been minimized.

@Pandrex247

Pandrex247 Oct 3, 2018

Member

Am I being blind or is this not actually used?

@@ -233,6 +241,7 @@ private SSLInfo init(String alias,
boolean tlsEnabled, boolean tlsEnabled11,boolean tlsEnabled12) throws Exception {
String protocol;
ArrayList<String> selectedProtocols = new ArrayList<>();

This comment has been minimized.

@Pandrex247

Pandrex247 Oct 3, 2018

Member

Same as above for this

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 11, 2018

Jenkins test please

@MeroRai MeroRai added v:Payara-5 and removed DO NOT MERGE labels Oct 11, 2018

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 11, 2018

Quick build and test passed!

@Pandrex247 Pandrex247 merged commit a6b25c5 into payara:master Oct 11, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 11, 2018

Merge pull request payara#3200 from smillidge/PAYARA-3128
PAYARA-3128 ensure we store and set supported protocols as well as ci…

MarkWareham pushed a commit to MarkWareham/Payara that referenced this pull request Oct 25, 2018

Merge pull request payara#3200 from smillidge/PAYARA-3128
PAYARA-3128 ensure we store and set supported protocols as well as ci…

MattGill98 pushed a commit to MattGill98/Payara that referenced this pull request Dec 10, 2018

Merge pull request payara#3200 from smillidge/PAYARA-3128
PAYARA-3128 ensure we store and set supported protocols as well as ci…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment