New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3153 OpenAPI doesn't support child schema on @...Param annotations #3228

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@MeroRai
Contributor

MeroRai commented Oct 3, 2018

No description provided.

@MeroRai MeroRai added the v:Payara-5 label Oct 3, 2018

@MeroRai MeroRai added this to the Payara 5.184 milestone Oct 3, 2018

@MeroRai MeroRai self-assigned this Oct 3, 2018

@MeroRai MeroRai requested a review from MattGill98 Oct 3, 2018

@MeroRai MeroRai changed the title from OpenAPI doesn't support child schema on @Param annotations to OpenAPI doesn't support child schema on @...Param annotations Oct 3, 2018

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 3, 2018

Jenkins test please

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 3, 2018

Passed the TCK

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 3, 2018

Quick build and test passed!

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 3, 2018

Jenkins test please

1 similar comment
@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 3, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 3, 2018

Quick build and test passed!

@MeroRai MeroRai changed the title from OpenAPI doesn't support child schema on @...Param annotations to PAYARA-3153 OpenAPI doesn't support child schema on @...Param annotations Oct 4, 2018

java.lang.reflect.Parameter parameter = java.lang.reflect.Parameter.class.cast(element);
schema.setType(ModelUtils.getSchemaType(parameter.getType()));
if (schema.getType() == SchemaType.ARRAY) {

This comment has been minimized.

@MattGill98

MattGill98 Oct 8, 2018

Member

This block is repeated in the if and the else, and so should be refactored.

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 8, 2018

Jenkins2 test please

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 8, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 8, 2018

Quick build and test passed!

@MattGill98 MattGill98 merged commit 9434e8e into payara:master Oct 8, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 10, 2018

Merge pull request payara#3228 from MeroRai/PAYARA-3153
PAYARA-3153 OpenAPI doesn't support child schema on @...Param annotations

MeroRai added a commit to MeroRai/Payara that referenced this pull request Oct 10, 2018

Merge pull request payara#3228 from MeroRai/PAYARA-3153
PAYARA-3153 OpenAPI doesn't support child schema on @...Param annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment