New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2764 Translate Payara only feature to Japanese #3259

Merged
merged 23 commits into from Nov 2, 2018

Conversation

Projects
None yet
5 participants
@khasunuma
Contributor

khasunuma commented Oct 10, 2018

No description provided.

@arjantijms arjantijms added the Huge PR! label Oct 12, 2018

@arjantijms arjantijms requested a review from Pandrex247 Oct 12, 2018

@khasunuma

This comment has been minimized.

Contributor

khasunuma commented Oct 17, 2018

I consider alternative some plans regarding to this issue as follows:

  1. Reduce the resource bundle - Remove l10n resources without Japanese. (Probably, it works well)
  2. Divide the pull request - DD/DG (required) and Other features (Optional)

Introducing new l10n features required to create new many l10n modules. So the PR becomes often too large size. I think it's better that this PR should be divided to several PRs now.

Please let me know your suggestion about this PR. Then, I'll once withdraw the PR and create several PRs instead of this.

@khasunuma

This comment has been minimized.

Contributor

khasunuma commented Oct 21, 2018

I removed l10n resources without Japanese. Currently there are ja_JP resources into new modules.

@MeroRai

Hi @khasunuma, after a brief look below are the things I would like to raise:

  1. Copyright header year needs updating on most of the files.
  2. Unicode on some of the files have been capitalised, these will need to be reverted.
@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 25, 2018

@khasunuma, forgot to mention, everything looks good on the admin console.

MeroRai added some commits Oct 30, 2018

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Oct 30, 2018

Jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 30, 2018

Quick build and test passed!

@payara payara deleted a comment from arjantijms Oct 31, 2018

@payara payara deleted a comment from payara-ci Oct 31, 2018

@payara payara deleted a comment from payara-ci Nov 1, 2018

@payara payara deleted a comment from arjantijms Nov 1, 2018

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 1, 2018

Jenkins test please

3 similar comments
@Pandrex247

This comment has been minimized.

Member

Pandrex247 commented Nov 1, 2018

Jenkins test please

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 1, 2018

Jenkins test please

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 2, 2018

Jenkins test please

@arjantijms arjantijms merged commit 9c1eefe into payara:master Nov 2, 2018

1 of 2 checks passed

Payara Quick Build Payara quick build failed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment