New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3091 Post Boot Commands Incorrect Quotation Mark Processing #3312

Merged
merged 3 commits into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@jGauravGupta
Contributor

jGauravGupta commented Oct 24, 2018

No description provided.

@jGauravGupta

This comment has been minimized.

Contributor

jGauravGupta commented Oct 24, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 24, 2018

Quick build and test passed!

1 similar comment
@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 24, 2018

Quick build and test passed!

@arjantijms arjantijms added this to the Payara 5.184 milestone Oct 24, 2018

}
tokenList.add(token);
}
return tokenList.toArray(new String[0]);

This comment has been minimized.

@arjantijms

arjantijms Oct 24, 2018

Member

Instead of new String[0], you could/should use a static variable here.

@arjantijms

Small improvement for the code

@jGauravGupta

This comment has been minimized.

Contributor

jGauravGupta commented Oct 25, 2018

jenkins test please

@payara-ci

This comment has been minimized.

Contributor

payara-ci commented Oct 25, 2018

Quick build and test passed!

@arjantijms arjantijms merged commit 6a21a26 into payara:master Oct 29, 2018

3 checks passed

Payara Quick Build Payara quick build passed!
Details
Payara Quick Build and Test Quick build and test passed!
Details
Payara Quick Test Payara quick tests passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment