New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3196 Upgrade grizzly-npn to 1.8.1 for JDK 8u191 #3357

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
5 participants
@Cousjava
Member

Cousjava commented Nov 1, 2018

fixes #3284

@Cousjava Cousjava added this to the Payara 5.184 milestone Nov 1, 2018

@Cousjava Cousjava self-assigned this Nov 1, 2018

@Cousjava Cousjava requested a review from MattGill98 Nov 1, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Nov 1, 2018

Jenkins test please

@MattGill98 MattGill98 changed the title from PAYARA-3197 Upgrade grizzly-npn to 1.8.1 for JDK 8u191 to PAYARA-3196 Upgrade grizzly-npn to 1.8.1 for JDK 8u191 Nov 1, 2018

@arjantijms arjantijms merged commit f7dd3f1 into payara:master Nov 1, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
@smillidge

This comment has been minimized.

Contributor

smillidge commented Nov 1, 2018

Do we need to add to the release notes that ONLY u191 now works?

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 2, 2018

This was an oversight in my testing. In my opinion that isn't a satisfactory behaviour, and may require a more complicated fix. What does everyone else think?

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Nov 5, 2018

Revert "Merge pull request payara#3357 from Cousjava/PAYARA-3196-npn-…
…8_191"

This reverts commit f7dd3f1, reversing
changes made to c38e5ce.
@johnmanko

This comment has been minimized.

johnmanko commented Nov 16, 2018

Should all grizzly-npn artifacts be replaced? I found the following:

glassfish/lib/grizzly-npn-bootstrap.jar
glassfish/modules/grizzly-npn-osgi.jar

I know definitely bootstrap, but how about osgi? Also, the API wasn't found in payara.

Grizzly NPN Bootstrap 1.8.1
Grizzly NPN OSGi 1.8.1
Grizzly NPN API 1.8.1

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 16, 2018

Hi @johnmanko,

No, only the bootstrap jar is required to be replaced.

Kind regards,

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment