New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3216 Make Weld concurrent bean loading configurable #3371

Merged
merged 7 commits into from Nov 19, 2018

Conversation

Projects
None yet
6 participants
@smillidge
Contributor

smillidge commented Nov 4, 2018

Concurrent Bean Loading is now configurable at the server level using asadmin.

@smillidge smillidge added this to the Payara 5.184 milestone Nov 4, 2018

@lprimak

lprimak approved these changes Nov 4, 2018

PAYARA-3216 implement Weld Executor Service to use internal Payara Ex…
…ecutor Service.

Enables mult-threaded bean deployment
@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 10, 2018

/code java.lang.IllegalArgumentException: invalid version "3.0.5.Final.payara-p1": invalid qualifier "Final.payara-p1"
at org.osgi.framework.Version.validate(Version.java:205)
at org.osgi.framework.Version.(Version.java:156)
at org.apache.felix.framework.util.VersionRange.parse(VersionRange.java:98)
at

@smillidge

This comment has been minimized.

Contributor

smillidge commented Nov 11, 2018

that is broken by the weld patch.

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 12, 2018

I think that because the patched Weld version is 3.0.5.Final.payara-p1 (as per our usual naming conventions), the generated bundle version is actually 3.0.5.Final_payara-p1. Would it be better to update the patched projects by changing the patch version name to the one produced by the bundle plugin, or to just add a weld.bundle.version property to our poms to fix this?

@payara payara deleted a comment from MattGill98 Nov 15, 2018

@payara payara deleted a comment from arjantijms Nov 15, 2018

@payara payara deleted a comment from arjantijms Nov 15, 2018

@Pandrex247 Pandrex247 changed the title from Payara 3216 Make Weld concurrent bean loading configurable to PAYARA-3216 Make Weld concurrent bean loading configurable Nov 15, 2018

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 16, 2018

#3412 depends on this

MeroRai and others added some commits Nov 16, 2018

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 16, 2018

jenkins test please

2 similar comments
@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 16, 2018

jenkins test please

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 16, 2018

jenkins test please

@MattGill98

This comment has been minimized.

Member

MattGill98 commented Nov 16, 2018

This looks like a legitimate test failure to me

@smillidge

This comment has been minimized.

Contributor

smillidge commented Nov 17, 2018

jenkins test please

@smillidge

This comment has been minimized.

Contributor

smillidge commented Nov 17, 2018

jenkins test please

@smillidge

This comment has been minimized.

Contributor

smillidge commented Nov 17, 2018

It was a bug and is now fixed.

@Pandrex247 Pandrex247 removed the CODE FREEZE label Nov 19, 2018

@Pandrex247 Pandrex247 merged commit 9a750f6 into payara:master Nov 19, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

@smillidge smillidge modified the milestones: Payara 5.184, 5.191 Nov 19, 2018

@smillidge smillidge removed the DO NOT MERGE label Nov 19, 2018

@Pandrex247 Pandrex247 modified the milestones: 5.191, Payara 5.184 Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment