New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3090 Support BASIC authentication with additional micro repositories #3376

Merged
merged 6 commits into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@Cousjava
Member

Cousjava commented Nov 5, 2018

No description provided.

@Cousjava Cousjava added this to the Payara 5.184 milestone Nov 5, 2018

@Cousjava Cousjava requested a review from rdebusscher Nov 5, 2018

@Cousjava

This comment has been minimized.

Member

Cousjava commented Nov 5, 2018

Jenkins test please

@Cousjava

This comment has been minimized.

Member

Cousjava commented Nov 5, 2018

Jenkins test please

} catch (MalformedURLException ex) {
LOGGER.log(Level.SEVERE, "{0} is not a valid URL and will be ignored", url);
}
repositoryURLs.add(url);

This comment has been minimized.

@rdebusscher

rdebusscher Nov 7, 2018

Contributor

for loop can be replaced with Collections.addAll(repositoryURLs, URLs);

@Cousjava

This comment has been minimized.

Member

Cousjava commented Nov 8, 2018

Jenkins test please

@arjantijms arjantijms merged commit f88fd5e into payara:master Nov 8, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

Cousjava added a commit to Cousjava/Payara that referenced this pull request Nov 9, 2018

Merge pull request payara#3376 from Cousjava/PAYARA-3090-basic-auth-m…
…icrorepo

PAYARA-3090 Support BASIC authentication with additional micro repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment