New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-2940 Secure Admin Support Portal Fix #3390

Merged
merged 3 commits into from Nov 10, 2018

Conversation

Projects
None yet
3 participants
@MattGill98
Member

MattGill98 commented Nov 7, 2018

Check JIRA for dependent PRs.

This PR basically does the following:

  • Converts index.html for support portal Angular app to JSF page. This allows the special admin indicator token to be fetched from the domain.xml when the page is loaded, and passed to the angular code.
  • Passes this token to the Angular code, which allows it to be sent with every REST request. This means that the user doesn't need to authenticate multiple times when browsing the support portal.

The main things I need checked are:

  • There are a couple of styling problems that appear to occur for me. I've checked and no styles appear to have been changed. All I can see is that the stylesheet order is inconsistent with the previous HTML solution. This would have been a problem anyway, but may have been revealed by this PR. If so this PR will raise a new issue for @diturner.
  • I think the token method I've used is perfectly secure, but this needs verifying by someone else.

@MattGill98 MattGill98 added this to the Payara 5.184 milestone Nov 7, 2018

@MattGill98 MattGill98 self-assigned this Nov 7, 2018

@MattGill98 MattGill98 requested review from arjantijms, MeroRai and diturner Nov 7, 2018

@MeroRai

This comment has been minimized.

Contributor

MeroRai commented Nov 8, 2018

@MattGill98, I test this locally and everything seems to work fine.

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 8, 2018

Jenkins test please

@MeroRai

MeroRai approved these changes Nov 9, 2018

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 9, 2018

@di can you take a look at this too?

@arjantijms arjantijms merged commit 1033c2a into payara:master Nov 10, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

MattGill98 added a commit to MattGill98/Payara that referenced this pull request Nov 13, 2018

Merge pull request payara#3390 from MattGill98/PAYARA-2940-Secure-Adm…
…in-Support-Portal-Fix

PAYARA-2940 Secure Admin Support Portal Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment