New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3252 refactor the healthcheck service to use the Payara Executor Service #3409

Merged
merged 3 commits into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@smillidge
Contributor

smillidge commented Nov 11, 2018

Reduce thread usage by using the common Executor Service

@smillidge smillidge added this to the Payara 5.184 milestone Nov 11, 2018

@smillidge smillidge requested a review from mulderbaba Nov 11, 2018

@arjantijms

This comment has been minimized.

Member

arjantijms commented Nov 12, 2018

Jenkins test please

@@ -114,24 +115,22 @@
@Inject
private HistoricHealthCheckEventStore healthCheckEventStore;
private List<NotifierExecutionOptions> notifierExecutionOptionsList;
@Inject
PayaraExecutorService executor;

This comment has been minimized.

@arjantijms

arjantijms Nov 12, 2018

Member

Might make this private for consistency?

@Pandrex247

This comment has been minimized.

Member

Pandrex247 commented Nov 14, 2018

Jenkins test please

@Pandrex247 Pandrex247 merged commit 2570d4a into payara:master Nov 15, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment