Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3358-asadmin-command-stop-domains-no-longer-works #3520

Merged
merged 1 commit into from Dec 17, 2018

Conversation

@mulderbaba
Copy link
Member

mulderbaba commented Dec 11, 2018

No description provided.

@mulderbaba mulderbaba added this to the 5.191 milestone Dec 11, 2018

@mulderbaba mulderbaba self-assigned this Dec 11, 2018

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Dec 11, 2018

jenkins test

@arjantijms arjantijms requested review from Cousjava and Pandrex247 Dec 12, 2018

@Pandrex247
Copy link
Member

Pandrex247 left a comment

I think this change might break the StopAllDomains command...
Would need to test it

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Dec 14, 2018

@mulderbaba Can you test with the StopAllDomains command? Fear is that StopAllDomains might nag for a parameter now.

@MattGill98
Copy link
Member

MattGill98 left a comment

Stop-all-domains still works fine for me as far as I can tell. LGTM

@Pandrex247 Pandrex247 merged commit 19fd99c into payara:master Dec 17, 2018

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.