Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
1 similar comment
MattGill98 left a comment
This works, but when the server is started you're presented with a limited list of commands still. I would personally like to see some logic to change this behaviour based on whether the server is up. I.e. if this option isn't specified and the server is up, default to true (and otherwise false).
Pandrex247 left a comment
I agree with Matt, I'm not fond of limiting it to local only commands unless you specifically tell it not to constraint itself. Also, with the current change, if you wanted look for remote only commands you'd need to explicitly tell it not to look for localonly to counteract the default of it being true (you can't have both):
I'm sure under one of the injectable environment services (e.g. ServerEnvironment) there's a "isRunning" method to do what Matt suggested