Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-running #3522

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
4 participants
@mulderbaba
Copy link
Member

mulderbaba commented Dec 11, 2018

No description provided.

@mulderbaba mulderbaba added this to the 5.191 milestone Dec 11, 2018

@mulderbaba mulderbaba self-assigned this Dec 11, 2018

@mulderbaba mulderbaba changed the title PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-runninga PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-running Dec 11, 2018

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Dec 11, 2018

jenkins test

1 similar comment
@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Dec 12, 2018

jenkins test

@MattGill98
Copy link
Member

MattGill98 left a comment

This works, but when the server is started you're presented with a limited list of commands still. I would personally like to see some logic to change this behaviour based on whether the server is up. I.e. if this option isn't specified and the server is up, default to true (and otherwise false).

@Pandrex247
Copy link
Member

Pandrex247 left a comment

I agree with Matt, I'm not fond of limiting it to local only commands unless you specifically tell it not to constraint itself. Also, with the current change, if you wanted look for remote only commands you'd need to explicitly tell it not to look for localonly to counteract the default of it being true (you can't have both): list-commands --localonly=false --remoteonly=true

I'm sure under one of the injectable environment services (e.g. ServerEnvironment) there's a "isRunning" method to do what Matt suggested

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Dec 18, 2018

@MattGill98 MattGill98 removed their assignment Dec 20, 2018

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-running branch from fed1e32 to 4930e58 Dec 20, 2018

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-running branch 2 times, most recently from f4aaf16 to f2c3a7d Jan 3, 2019

@mulderbaba mulderbaba closed this Jan 13, 2019

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3360-asadmin-list-commands-only-works-when-domain-is-running branch from f2c3a7d to af07159 Jan 13, 2019

@mulderbaba mulderbaba reopened this Jan 13, 2019

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Jan 13, 2019

jenkins test

@mulderbaba

This comment has been minimized.

Copy link
Member Author

mulderbaba commented Jan 14, 2019

jenkins test

@arjantijms arjantijms merged commit 89c7394 into payara:master Jan 15, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.