Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3357 Fix Interactive Asadmin Prompt Errors #3528

Merged
merged 9 commits into from Jan 21, 2019

Conversation

Projects
None yet
5 participants
@Pandrex247
Copy link
Member

Pandrex247 commented Dec 13, 2018

Fixes the issue with the terminal immediately returning on prompts when using asadmin interactively

@Pandrex247 Pandrex247 added this to the 5.191 milestone Dec 13, 2018

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Dec 13, 2018

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Dec 13, 2018

Found some more errors, closing for now - this is a tricky one.

@Pandrex247 Pandrex247 closed this Dec 13, 2018

@Pandrex247 Pandrex247 reopened this Dec 17, 2018

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Dec 17, 2018

Jenkins test please

@arjantijms arjantijms requested a review from MarkWareham Dec 21, 2018

@MarkWareham
Copy link
Contributor

MarkWareham left a comment

Uncertain on nesting of IF

@mulderbaba

This comment has been minimized.

Copy link
Member

mulderbaba commented Dec 28, 2018

jenkins test

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Jan 18, 2019

jenkins test

@Pandrex247 Pandrex247 merged commit a6b636c into payara:master Jan 21, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jan 21, 2019

Merge pull request payara#3528 from Pandrex247/PAYARA-3357
PAYARA-3357 Fix Interactive Asadmin Prompt Errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.