Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-546 Allow setting SO_KeepAlive on the server side #3534

Merged
merged 10 commits into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@Pandrex247
Copy link
Member

Pandrex247 commented Dec 19, 2018

Expansion on #3533 that allows setting SO_KEEPALIVE on the server side, and also allows configuration on a per-listener basis.

This won't work on multi-homed environments - will look at adding this later.

Show resolved Hide resolved ...c/main/java/org/glassfish/enterprise/iiop/impl/IIOPSSLSocketFactory.java Outdated
Show resolved Hide resolved ...c/main/java/org/glassfish/enterprise/iiop/impl/IIOPSSLSocketFactory.java Outdated
Show resolved Hide resolved ...c/main/java/org/glassfish/enterprise/iiop/impl/IIOPSSLSocketFactory.java Outdated

// For each listener, find one with a matching port
for (IiopListener iiopListener : IIOPUtils.getInstance().getIiopService().getIiopListener()) {
if (Integer.valueOf(iiopListener.getPort()) == socket.getPort()) {

This comment has been minimized.

@lprimak

lprimak Dec 21, 2018

Contributor

Not quite sure, but I think you can do the address check so the socket's address is compared to iiopListener's address. So if you have multi-homed scenario, the different addresses can be compared

This comment has been minimized.

@Pandrex247

Pandrex247 Jan 7, 2019

Author Member

It's not quite as simple as a quick check: a) it comes out in String format so the only way to compare is literally b) the values returned by the socket and the listener are typically different (e.g. 0.0.0.0 vs. 127.0.0.1, or with extra additional network address gubbins) - we'd have to add functionality for resolving the addresses ourselves.

I think that's enough of a task to be its own Jira.

@mulderbaba mulderbaba added this to the 5.191 milestone Dec 27, 2018

@Pandrex247 Pandrex247 changed the title PAYARA-546 Allow setting SO_KeepAlive on the server side (Extended) PAYARA-546 Allow setting SO_KeepAlive on the server side Jan 7, 2019

Extension Jira created - PAYARA-3437

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 18, 2019

Jenkins test please

1 similar comment
@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 18, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 21, 2019

Jenkins test please

2 similar comments
@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 21, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Keeps failing on the ejb_remoteview test - either something has changed since I made the PR or my luck is awful and that intermittent test just keeps failing.

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

3 similar comments
@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 22, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 23, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 23, 2019

This passes locally - it is simply failing on the intermittent test now.

@Pandrex247

This comment has been minimized.

Copy link
Member Author

Pandrex247 commented Jan 23, 2019

Jenkins test please

@Pandrex247 Pandrex247 merged commit 6d95d66 into payara:master Jan 23, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

@Pandrex247 Pandrex247 deleted the Pandrex247:PAYARA-546-Part2 branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.