Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3031 HTTP/2 Trailer Issue #3545

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@MattGill98
Copy link
Member

MattGill98 commented Jan 2, 2019

Depends on: payara/Payara_PatchedProjects#213.

Needs fairly rigorous testing.

@MattGill98 MattGill98 self-assigned this Jan 2, 2019

@MattGill98 MattGill98 requested review from arjantijms and MarkWareham Jan 2, 2019

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Jan 2, 2019

Jenkins test please

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Jan 2, 2019

@MattGill98

Needs fairly rigorous testing.

How do you propose to test this change? Add a series of tests to e.g. EE 8 samples?

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Jan 2, 2019

Jenkins test please

@arjantijms arjantijms merged commit 6faa5de into payara:master Jan 3, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Jan 3, 2019

@arjantijms I would recommend investigating the possibility of an extension to the HTTP/2 test that just adds trailers and checks they all go through. Also if anyone notices general Grizzly problems either manually or in Jenkins (you know the classics) then let me know!

@MattGill98 MattGill98 deleted the MattGill98:PAYARA-3031-HTTP2-Trailer-Issue branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.