Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3434 optimise FileArchive #3616

Merged
merged 7 commits into from Feb 26, 2019

Conversation

Projects
None yet
6 participants
@Cousjava
Copy link
Member

Cousjava commented Jan 16, 2019

No description provided.

@Cousjava Cousjava added this to the 5.191 milestone Jan 16, 2019

@Cousjava Cousjava self-assigned this Jan 16, 2019

@Cousjava Cousjava requested a review from fturizo Jan 16, 2019

@@ -678,6 +678,7 @@ public void postDeployClean(boolean isFinalClean) {
for (String className : classNamesToClean) {
transientAppMetaData.remove(className);
}
com.sun.enterprise.deploy.shared.FileArchive.clearCache();

This comment has been minimized.

@svendiedrichsen

svendiedrichsen Jan 16, 2019

Contributor

Shouldn't clearCache be called when isFinalClean is true?

@arjantijms arjantijms requested review from jGauravGupta and MeroRai Jan 18, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Jan 18, 2019

Jenkins test please

@Cousjava Cousjava force-pushed the Cousjava:PAYARA-3434-optimise-filearchive branch from d68f740 to af09e76 Jan 18, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Jan 18, 2019

Jenkins test please

1 similar comment
@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Jan 21, 2019

Jenkins test please

@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Jan 29, 2019

Jenkins test please

@MarkWareham

This comment has been minimized.

Copy link
Contributor

MarkWareham commented Feb 1, 2019

jenkins test please

@MarkWareham

This comment has been minimized.

Copy link
Contributor

MarkWareham commented Feb 1, 2019

failure due to something else

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Feb 5, 2019

jenkins test please

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Feb 7, 2019

jenkins test please

@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Feb 8, 2019

Test failure is due to CDI Async test, no idea why as this PR does not touch CDI

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Feb 8, 2019

jenkins test please

@MarkWareham

This comment has been minimized.

Copy link
Contributor

MarkWareham commented Feb 8, 2019

Test problem tracked with QA-154 Jira

@Cousjava

This comment has been minimized.

Copy link
Member Author

Cousjava commented Feb 26, 2019

Jenkins test please

@Pandrex247 Pandrex247 merged commit fd679e7 into payara:master Feb 26, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.