Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3438: Improve usability MP Health endpoint as readinessProbe #3632

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
6 participants
@rdebusscher
Copy link
Contributor

rdebusscher commented Jan 18, 2019

… for k8s

@rdebusscher rdebusscher requested review from Cousjava and Pandrex247 Jan 18, 2019

@svendiedrichsen

This comment has been minimized.

Copy link
Contributor

svendiedrichsen commented Jan 18, 2019

@rdebusscher Looks as if this only works if you have a single app to deploy or how do you specify the target number of deployed applications?

@rdebusscher

This comment has been minimized.

Copy link
Contributor Author

rdebusscher commented Jan 18, 2019

@svendiedrichsen Yes it works optimally for a single app in Payara Micro. Having multiple apps on 1 Payara Micro doesn't make sense if you like to optimize the scale for each app differently.

@mulderbaba mulderbaba added this to the 5.191 milestone Jan 19, 2019

@Pandrex247
Copy link
Member

Pandrex247 left a comment

I'll need to check the spec and TCK - this means that if no application is deployed then the healthcheck will fail (unless I'm misreading it)

@rdebusscher

This comment has been minimized.

Copy link
Contributor Author

rdebusscher commented Jan 25, 2019

@Pandrex247 regarding spec and TCK -> it is not specified in the 1.0 release. But will be included within 1.1 (eclipse/microprofile-health#35)

This update makes it possible to use the health check as readinessProbe. Otherwise, people need to create their own solution otherwise 404 status responses will be send when scaling up in k8s.

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Jan 29, 2019

What do we need to do to get this in?

@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Jan 31, 2019

Jenkins test

1 similar comment
@arjantijms

This comment has been minimized.

Copy link
Member

arjantijms commented Feb 8, 2019

Jenkins test

@Pandrex247 Pandrex247 merged commit aba8cb5 into payara:master Feb 8, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

@rdebusscher rdebusscher deleted the rdebusscher:PAYARA-3438 branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.