Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Service Name and Namespace Options for Kubernetes Cluster mode Optional PAYARA-3310 #3646

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@jbee
Copy link
Contributor

jbee commented Jan 22, 2019

Addressing https://payara.atlassian.net/browse/PAYARA-3310.

After some discussion it was decided to only allow both or none argument. If only one argument would be passed it cannot be decided if namespace or service-name was meant. To avoid confusion we do not allow single option.

When passing options via SetHazelcastConfiguration both parameters are already optional so that any combination can be set. The namespace in HazelcastRuntimeConfiguration uses a default of "default" so one needs to explicitly set this to empty to not set any of the two.

@jbee jbee self-assigned this Jan 22, 2019

@jbee jbee requested a review from Pandrex247 Jan 22, 2019

@Pandrex247 Pandrex247 added this to the 5.191 milestone Jan 23, 2019

@Pandrex247

This comment has been minimized.

Copy link
Member

Pandrex247 commented Jan 23, 2019

Jenkins test please

2 similar comments
@Pandrex247

This comment has been minimized.

Copy link
Member

Pandrex247 commented Jan 24, 2019

Jenkins test please

@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Jan 24, 2019

Jenkins test please

@smillidge smillidge changed the title Make Service Name and Namespace Options for Kubernetes Cluster mode Optional Make Service Name and Namespace Options for Kubernetes Cluster mode Optional PAYARA-3310 Jan 26, 2019

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Jan 26, 2019

jenkins test please

@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Jan 28, 2019

Jenkins test please

@Pandrex247

This comment has been minimized.

Copy link
Member

Pandrex247 commented Jan 29, 2019

Result of test with following command: java -jar payara-micro.jar --deploy rest-jcache.war --autobindhttp --clustermode kubernetes --name payara-micro

java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at fish.payara.micro.boot.loader.MainMethodRunner.run(MainMethodRunner.java:48)
        at fish.payara.micro.boot.loader.Launcher.launch(Launcher.java:107)
        at fish.payara.micro.boot.loader.Launcher.launch(Launcher.java:70)
        at fish.payara.micro.boot.PayaraMicroLauncher.main(PayaraMicroLauncher.java:79)
        at fish.payara.micro.PayaraMicro.main(PayaraMicro.java:397)
Caused by: fish.payara.micro.BootstrapException: String index out of range: -1
        at fish.payara.micro.impl.PayaraMicroImpl.bootStrap(PayaraMicroImpl.java:1049)
        at fish.payara.micro.impl.PayaraMicroImpl.main(PayaraMicroImpl.java:200)
        ... 9 more
Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1931)
        at fish.payara.micro.impl.PayaraMicroImpl.configureHazelcast(PayaraMicroImpl.java:1888)
        at fish.payara.micro.impl.PayaraMicroImpl.bootStrap(PayaraMicroImpl.java:1006)
        ... 10 more
@jbee

This comment has been minimized.

Copy link
Contributor Author

jbee commented Jan 30, 2019

Jenkins test please

@smillidge

This comment has been minimized.

Copy link
Contributor

smillidge commented Feb 2, 2019

Needs @Pandrex247 approval

@Pandrex247 Pandrex247 merged commit 556c82d into payara:master Feb 5, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.