Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3132 Incorporate Help Documentation Back #3723

Merged
merged 12 commits into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@MattGill98
Copy link
Member

MattGill98 commented Feb 12, 2019

No description provided.

@MattGill98 MattGill98 added this to the 5.191 milestone Feb 12, 2019

@MattGill98 MattGill98 self-assigned this Feb 12, 2019

@MattGill98 MattGill98 requested review from Pandrex247 and MeroRai Feb 12, 2019

@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Feb 12, 2019

jenkins test please

@MeroRai
Copy link
Contributor

MeroRai left a comment

Hi, few of the links on the documentation links to Oracle docs. This might cause legal problems, I will recommend you link it to the docs provided by Eclipse.

@MattGill98 MattGill98 force-pushed the MattGill98:PAYARA-3132-Incorporate-Help-Documentation-Back branch from 57fb22d to b08de6e Feb 18, 2019

@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Feb 18, 2019

jenkins test please

@MattGill98 MattGill98 requested a review from smillidge Feb 18, 2019

@Pandrex247
Copy link
Member

Pandrex247 left a comment

There's still some links to oracle docs (I spotted links to Java SE docs)
Are we allowed to do that...?

mistake

@MattGill98 MattGill98 requested a review from MeroRai Feb 20, 2019

@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Feb 22, 2019

jenkins test please

@MattGill98 MattGill98 force-pushed the MattGill98:PAYARA-3132-Incorporate-Help-Documentation-Back branch from 666a4c1 to 313c6d3 Feb 22, 2019

@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Feb 22, 2019

jenkins test please

@MattGill98

This comment has been minimized.

Copy link
Member Author

MattGill98 commented Feb 25, 2019

Rebased to clear up commit history to make it a cleaner merge (please don't squash and merge - there's way too many changes). Only changed commit is 313c6d3, where I cleared up remaining Oracle website references with a script.

@Pandrex247 Pandrex247 merged commit d5db0fc into payara:master Feb 25, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@MattGill98 MattGill98 deleted the MattGill98:PAYARA-3132-Incorporate-Help-Documentation-Back branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.