Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3492-Upgrade-JLine-version-to-v3.x #3739

Merged

Conversation

@mulderbaba
Copy link
Contributor

commented Feb 17, 2019

No description provided.

@mulderbaba mulderbaba added this to the 5.191 milestone Feb 17, 2019

@mulderbaba mulderbaba self-assigned this Feb 17, 2019

@mulderbaba

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

jenkins test

@Pandrex247

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Looks like the new version doesn't like multi-commands.

 [testng] ERROR>	at org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:562)
 [testng] ERROR>	at org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:384)
 [testng] ERROR>	at com.sun.enterprise.admin.cli.MultimodeCommand.executeCommands(MultimodeCommand.java:229)
 [testng] ERROR>	at com.sun.enterprise.admin.cli.MultimodeCommand.executeCommand(MultimodeCommand.java:181)
 [testng] ERROR>	at com.sun.enterprise.admin.cli.CLICommand.execute(CLICommand.java:327)
 [testng] ERROR>	at com.sun.enterprise.admin.cli.AdminMain.executeCommand(AdminMain.java:363)
 [testng] ERROR>	at com.sun.enterprise.admin.cli.AdminMain.doMain(AdminMain.java:298)
 [testng] ERROR>	at org.glassfish.admin.cli.AsadminMain.main(AsadminMain.java:56)```

@MarkWareham MarkWareham requested review from Cousjava and Pandrex247 Feb 18, 2019

@Pandrex247 Pandrex247 removed this from the 5.191 milestone Feb 25, 2019

@arjantijms arjantijms added this to the 5.192 milestone Feb 27, 2019

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3492-Upgrade-JLine-version-to-v3.x branch 2 times, most recently from 91d1073 to d98c1b8 Mar 13, 2019

@Cousjava
Copy link
Member

left a comment

Does not work in multimode

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3492-Upgrade-JLine-version-to-v3.x branch from d98c1b8 to 5250879 Mar 30, 2019

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3492-Upgrade-JLine-version-to-v3.x branch 4 times, most recently from 93aa198 to fcdd299 Apr 8, 2019

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3492-Upgrade-JLine-version-to-v3.x branch from fcdd299 to 9474b51 Apr 24, 2019

@mulderbaba mulderbaba force-pushed the mulderbaba:PAYARA-3492-Upgrade-JLine-version-to-v3.x branch from 641f5de to 899e9ec Apr 24, 2019

@mulderbaba

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

jenkins test

@jbee

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

jenkins test please

@mulderbaba mulderbaba closed this May 1, 2019

@MeroRai

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Does not work in multimode

@Cousjava, tested it locally, it works in multimode.

MeroRai added 2 commits May 1, 2019

@MeroRai MeroRai reopened this May 2, 2019

@mulderbaba

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@MeroRai this will break on the quicklook tests.

@MeroRai

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

@MeroRai this will break on the quicklook tests.

@mulderbaba, I have fixed it locally

@MeroRai

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

jenkins test please

@Cousjava
Copy link
Member

left a comment

multimode autocomplete is broken

@MeroRai MeroRai requested a review from Cousjava May 8, 2019

@MeroRai MeroRai requested a review from fturizo May 9, 2019

@Pandrex247
Copy link
Member

left a comment

Echoes password

} finally {
if (lineReader != null && lineReader.getTerminal() != null) {
try {
lineReader.getTerminal().close();

This comment has been minimized.

Copy link
@Pandrex247

Pandrex247 May 9, 2019

Member

I assume this can't simply be included in a try-with-resources?


}
}
/*

This comment has been minimized.

Copy link
@Pandrex247

Pandrex247 May 9, 2019

Member

Line endings change?

@arjantijms arjantijms assigned MeroRai and unassigned mulderbaba May 13, 2019

@arjantijms arjantijms modified the milestones: 5.192, 5.193 May 16, 2019

@MeroRai MeroRai removed the DO NOT MERGE label May 24, 2019

MeroRai added 3 commits May 24, 2019

@MeroRai MeroRai requested review from Pandrex247 and Cousjava Jun 3, 2019

@Pandrex247
Copy link
Member

left a comment

I prefer it not printing out * characters as you enter a password.

@MeroRai

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

jenkins test please

@payara payara deleted a comment from arjantijms Jun 10, 2019

@Pandrex247 Pandrex247 merged commit 8130ecf into payara:master Jun 11, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.