Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3386: Update login.conf with login module #3837

Merged
merged 12 commits into from Mar 25, 2019

Conversation

Projects
None yet
5 participants
@pdudits
Copy link
Contributor

commented Mar 14, 2019

Login Module registration can be requested via --login-module parameter to create-auth-realm. In such case property jaas-context is required for the realm.

In the Admin UI, the default jaas context is now prefilled when creating a predefined realm. Login modules can be registered by enabling a checkbox and filling in the login module class name (and JAAS context if not provided by predefined class)

@pdudits pdudits requested a review from arjantijms Mar 14, 2019

@arjantijms

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Jenkins test please

@pdudits pdudits force-pushed the pdudits:payara-3386 branch from 8610e39 to 7cdcc8b Mar 18, 2019

attrMap.put("fileJaax", "fileRealm");
attrMap.put("ldapJaax", "ldapRealm" );
attrMap.put("solarisJaax", "solarisRealm");
attrMap.put("jdbcJaax", "jdbcRealm");

This comment has been minimized.

Copy link
@pdudits

pdudits Mar 18, 2019

Author Contributor

image

<sun:property id="loginModule" labelAlign="left" noWrap="#{true}" overlapLabel="#{false}" label="$resource{i18nc.realm.loginmodule.class}" helpText="$resource{i18nc.realm.loginmodule.classHelp}" >
<sun:textField id="loginModule" text="#{attrMap.loginModuleClass}" columns="$int{57}" maxLength="#{sessionScope.fieldLengths['maxLength.realm.Classname']}" />
</sun:property>
</sun:propertySheetSection>

This comment has been minimized.

Copy link
@pdudits

pdudits Mar 18, 2019

Author Contributor

image

if (testtype.match('none')){
var loginModuleJaax = document.getElementById('#{loginModuleJaax}');
loginModuleJaax.style.display = 'none';

This comment has been minimized.

Copy link
@pdudits

pdudits Mar 18, 2019

Author Contributor

For predefined classes, that already have an attribute for JAAS Context, it is not displayed for login module configuration:

image

@pdudits pdudits requested a review from Pandrex247 Mar 18, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

jenkins test please

@arjantijms
Copy link
Member

left a comment

Looks good, but does need some updating of the license headers

@Pandrex247 Pandrex247 changed the title Payara-3386: Update login.conf with login module PAYARA-3386: Update login.conf with login module Mar 18, 2019

@pdudits pdudits requested a review from arjantijms Mar 19, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

jenkins test please

@Cousjava
Copy link
Member

left a comment

If I use a custom realm class name then login.conf is not updated

@Cousjava

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Further to my review: the issue is that I did not supply all fields and the UI did not indicate that I needed to or throw an error when I submitted it

@mulderbaba mulderbaba added this to the 5.192 milestone Mar 22, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@Cousjava, I improved the UI a bit, try again, please

@pdudits pdudits requested a review from Cousjava Mar 25, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

jenkins test

@Cousjava
Copy link
Member

left a comment

Tested and all works

@arjantijms arjantijms merged commit 6488cbd into payara:master Mar 25, 2019

21 of 25 checks passed

security/snyk - appserver/common/pom.xml (payara-ci) Test in progress
security/snyk - appserver/installer/pom.xml (payara-ci) Test in progress
security/snyk - appserver/orb/pom.xml (payara-ci) Test in progress
security/snyk - appserver/transaction/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details

@pdudits pdudits deleted the pdudits:payara-3386 branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.