Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3709 Equals sign is added to system properties with empty value even if it's already in the key #3887

Merged
merged 21 commits into from Apr 15, 2019

Conversation

Projects
None yet
6 participants
@AlanRoth
Copy link
Contributor

commented Apr 10, 2019

No description provided.

AlanRoth added some commits Apr 5, 2019

@AlanRoth

This comment has been minimized.

Copy link
Owner Author

commented on fe8c2fe Apr 10, 2019

and changed imports so less is improted

@cubastanley
Copy link
Contributor

left a comment

Just the pom formatting for me, otherwise I'm a happy lad

AlanRoth added some commits Apr 11, 2019

@Pandrex247
Copy link
Member

left a comment

Minor formatting issues, otherwise fine 👍
Tested locally and works

@MarkWareham

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Alan is making further changes, hence the DO NOT MERGE label

AlanRoth added some commits Apr 11, 2019

Merge pull request #3 from AlanRoth/master
update PAYARA-3709 branch

@AlanRoth AlanRoth requested a review from MarkWareham Apr 11, 2019

Test didn't need to throw a transaction failure
That was from a different solution to the test

@AlanRoth AlanRoth requested a review from Pandrex247 Apr 12, 2019

Changes made

@AlanRoth AlanRoth requested review from cubastanley and removed request for MattGill98 Apr 12, 2019

options.append("=").append(entry.getValue());

if (key != null && !key.trim().isEmpty() && key.startsWith("-D")) {
if (value == null || value.equals("null")) {

This comment has been minimized.

Copy link
@MarkWareham

MarkWareham Apr 15, 2019

Contributor

Could the text "null" ever be a valid value?

This comment has been minimized.

Copy link
@AlanRoth

AlanRoth Apr 15, 2019

Author Contributor

Upon further thought, I think it should be accepted, "null" is a perfectly valid Gaelic name.

Show resolved Hide resolved .gitignore Outdated
Show resolved Hide resolved ...st/java/fish/payara/admin/rest/resources/CollectionLeafResourceTest.java Outdated

AlanRoth added some commits Apr 15, 2019

Added wildcard to ignore nbproject
Instead of listing separate nbproject directories

@AlanRoth AlanRoth removed the DO NOT MERGE label Apr 15, 2019

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

jenkins test please

@Pandrex247 Pandrex247 merged commit b9c592e into payara:master Apr 15, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

Pandrex247 added a commit to Pandrex247/Payara that referenced this pull request Jun 12, 2019

Merge pull request payara#3887 from AlanRoth/PAYARA-3709
PAYARA-3709 Equals sign is added to system properties with empty value even if it's already in the key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.