Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3781 Use MemberAddressProvider only if --interfaces is not specified #3915

Merged
merged 2 commits into from May 13, 2019

Conversation

Projects
None yet
7 participants
@edthorne
Copy link
Contributor

commented Apr 24, 2019

Fixes #3914

@mulderbaba mulderbaba added this to the 5.192 milestone Apr 24, 2019

@mulderbaba

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

jenkins test

@svendiedrichsen

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@edthorne The MemberAddressPicker in line 169 uses the provided interfaces list to find a matching one. This list will always be empty. It looks obsolete to me now. It didn't handle wildcards anyway.

@edthorne

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@svendiedrichsen your point about not handling the wildcards is why I'm seeking additional information about the bug. While my solution has solved the problem for me. I'm not 100% certain it's the correct fix.

My original plan was to add wildcard support to MemberAddressPicker and then I realized that the solution provided in the PR could be the correct one. If it is in fact correct, I'll remove the code from MemberAddressPicker. The comments at the top of the findAppropriateInterfaces method suggest other checks should be taking place but aren't actually implemented.

@smillidge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Thanks for the PR it's appreciated I will review.

To merge we will need a CLA on file see https://github.com/payara/Payara/blob/master/.github/CONTRIBUTING.md

@smillidge smillidge changed the title PAYARA-3914 Use MemberAddressProvider only if --interfaces is not specified Use MemberAddressProvider only if --interfaces is not specified Apr 25, 2019

@edthorne

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

The CLA should be on file for a prior PR submission.

@smillidge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Yes we do have a CLA on file. Apologies

@smillidge smillidge added CLA and removed Awaiting CLA labels Apr 25, 2019

@Pandrex247 Pandrex247 changed the title Use MemberAddressProvider only if --interfaces is not specified PAYARA-3781 Use MemberAddressProvider only if --interfaces is not specified Apr 29, 2019

@smillidge

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Looks correct to me.

@edthorne

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@smillidge do you want me to remove the dead code mentioned earlier?

@smillidge

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

Yes that would be good thanks

@MeroRai

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

jenkins test please

@arjantijms arjantijms merged commit 5f0acb9 into payara:master May 13, 2019

41 of 45 checks passed

security/snyk - appserver/admin/pom.xml (payara-ci) Test in progress
security/snyk - appserver/flashlight/pom.xml (payara-ci) Test in progress
security/snyk - appserver/orb/pom.xml (payara-ci) Test in progress
security/snyk - appserver/packager/pom.xml (payara-ci) Test in progress
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.