Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3755: Improve JSON-B support in ejb-http-client #3945

Merged
merged 6 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@pdudits
Copy link
Contributor

commented May 13, 2019

This builds upon #3931 (and the diff will get simpler once that one is merged) and payara/patched-src-yasson#3 in order to handle all of the test cases present in payara/payara-samples#9. Needs payara/Payara_PatchedProjects#244 to build properly.

512fbc7 handles class names especially for primitive types and null
7148154 adds dependency of client to same version of Yasson as in server, because all public Yasson versions at this time have issues with handling primitive types (and null)
177d55b maintains proper generic type of method parameters, so that JSON-B can properly deserialize parameters of types List<Pojo>, instead of creating List<Map<String,Object>> instead.

@pdudits pdudits requested review from jbee and arjantijms May 13, 2019

pdudits added some commits May 7, 2019

PAYARA-3755: Properly serialize class names and handle null return va…
…lues

Use snapshot of Yasson that fixed other serialization issues.
PAYARA-3755: Use app server's JSON-B implementation in client
Also exclude Jakarta dependencies as long as we depend on javax ones

Signed-off-by: Patrik Dudits <patrik.dudits@payara.fish>
PAYARA-3755: Preserve generic type information from the signature
Signed-off-by: Patrik Dudits <patrik.dudits@payara.fish>
PAYARA-3755: Depend on release version of yasson
Signed-off-by: Patrik Dudits <patrik.dudits@payara.fish>

@pdudits pdudits force-pushed the pdudits:payara-3755 branch from 4130bcf to 3f936ad May 14, 2019

@jbee

jbee approved these changes May 14, 2019

Copy link
Contributor

left a comment

Question were discussed via teams. No changes required. Correctness was verified by running the added test cases payara/payara-samples#9.

@@ -24,3 +24,4 @@ nb-configuration.xml
appserver/extras/arquillian-containers/payara-common/dependency-reduced-pom.xml
appserver/tests/quicklook/quicklook_summary.txt
**/nbproject
.flattened-pom.xml

This comment has been minimized.

Copy link
@Pandrex247

Pandrex247 May 15, 2019

Member

Thank you

@pdudits

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

jenkins test please

@pdudits pdudits merged commit 1545493 into payara:master May 15, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@pdudits pdudits deleted the pdudits:payara-3755 branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.