Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3691 Updated metro to read WSDL from WEB-INF #3972

Merged
merged 5 commits into from Jun 19, 2019

Conversation

@arjantijms
Copy link
Contributor

commented May 22, 2019

Payara-3691

Core commit in:

Updated WSIT commit in:

Depends on patched projects binaries.

@arjantijms arjantijms added this to the 5.193 milestone May 22, 2019

@arjantijms arjantijms self-assigned this May 22, 2019

@arjantijms arjantijms changed the title Payara-3691 Updated metro to read WSDL from WEB-INF PAYARA-3691 Updated metro to read WSDL from WEB-INF May 22, 2019

@Pandrex247

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Conflicting files
appserver/webservices/metro-glue/pom.xml

L(・o・)」

@Pandrex247

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Jenkins test please

@Pandrex247
Copy link
Member

left a comment

How is this relying on patched projects updates atm? No versions have been updated in any poms

@arjantijms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

How is this relying on patched projects updates atm? No versions have been updated in any poms

Indeed, that still has to be done. The first commit is adding the resource loader to load from WEB-INF.

PAYARA-3691 Updated to Metro (WSIT) 2.4.3.payara-p3
This version of Metro takes the resource loader into account.

Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@arjantijms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Jenkins test please

@Pandrex247
Copy link
Member

left a comment

Built, but don't really have a test for this.
Just a couple quibbles

@Pandrex247
Copy link
Member

left a comment

Don't have an example to test but looks fine from a surface level

@@ -138,12 +138,12 @@
HazelcastCore hazelcastCore;

@Inject
@Named(ServerEnvironment.DEFAULT_INSTANCE_NAME)
@Named(DEFAULT_INSTANCE_NAME)

This comment has been minimized.

Copy link
@Cousjava

Cousjava Jun 18, 2019

Member

This change is unnecessary

@pdudits
Copy link
Contributor

left a comment

I believe this should put behind a feature switch, as this is grey area and can defuse some WSDL files that were by now lying dormant.

@arjantijms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

Jenkins test please

@MarkWareham MarkWareham removed the request for review from MattGill98 Jun 19, 2019

@arjantijms arjantijms merged commit ec52883 into payara:master Jun 19, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@arjantijms arjantijms deleted the arjantijms:PAYARA-3691-wsdl-from-webinf branch Jul 29, 2019

AlanRoth pushed a commit to AlanRoth/Payara that referenced this pull request Aug 13, 2019
Merge pull request payara#3972 from jansupol/cdi_deprecated
Stop using deprecated CDI API (addAnnotatedType). Continue payara#3845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.