Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3876 Added profiles for adding and embedding source in build #3987

Merged
merged 4 commits into from Jun 13, 2019

Conversation

@arjantijms
Copy link
Contributor

commented May 29, 2019

PAYARA-3876

Signed-off-by: arjantijms arjan.tijms@gmail.com

PAYARA-3876 Added profiles for adding and embedding source in build
Signed-off-by: arjantijms <arjan.tijms@gmail.com>

@arjantijms arjantijms added this to the 5.193 milestone May 29, 2019

@arjantijms arjantijms requested review from pdudits and MattGill98 May 29, 2019

@arjantijms arjantijms self-assigned this May 29, 2019

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>

This comment has been minimized.

Copy link
@pdudits

pdudits May 31, 2019

Contributor

Given the packaging process is complicated already, wouldn't be better to define those source-only steps in profile only?

This comment has been minimized.

Copy link
@arjantijms

arjantijms Jun 12, 2019

Author Contributor

Lines 495 to 498 are in the embed-source profile, so the source-only steps are already in profile. Or did you mean something else?

This comment has been minimized.

Copy link
@pdudits

pdudits Jun 12, 2019

Contributor

Yes, whether you considered configuration of this execution to be put here as well. The <phase>none</phase> is easy to miss when reasoning about what the actual process is.

This comment has been minimized.

Copy link
@arjantijms

arjantijms Jun 13, 2019

Author Contributor

I put it there since that's how the IPS profile works too. All the config in one place, and then the profiles activate it.

nucleus/pom.xml Outdated Show resolved Hide resolved
PAYARA-3876 Fix appclient resources
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@Cousjava

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

How is this different from mvn pre-site -Psource?

@arjantijms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

How is this different from mvn pre-site -Psource?

This embeds the source inside the java jar archives, so the IDE always finds it. mvn pre-site -Psource does nothing like that.

PAYARA-3876 Addressing feedback - Merged profiles into 1, added comment
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
@arjantijms

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Jenkins test please

@arjantijms arjantijms merged commit 3526be0 into payara:master Jun 13, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@arjantijms arjantijms deleted the arjantijms:PAYARA-3876-embed-source branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.