Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3918 Fixed typo in path. #3990

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@johnmanko
Copy link
Contributor

commented May 30, 2019

No description provided.

@johnmanko johnmanko changed the title Fixed type in path. Fixed typepo in path. May 30, 2019

@johnmanko johnmanko changed the title Fixed typepo in path. Fixed typo in path. May 30, 2019

@jbee
jbee approved these changes May 30, 2019
@smillidge

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Thanks good catch

@johnmanko

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

I seems like there are a lot of places where META-INF, WEB-INF, *.xml strings are defined. I wouldn't mind consolidating all of those to a single definition class some place. If you're ok with that, I'll work on it. Which class/interface should define all of those? There is Payara/appserver/resources/resources-connector/src/main/java/org/glassfish/resources/api/ResourceConstants.java, but I think the current ones defined in there will also have to be renamed to account for WEB-INF. Perhaps move the definitions from Payara/appserver/resources/resources-connector/src/main/java/org/glassfish/resources/util/ResourceUtil.java to ResourceConstants.java?

@cubastanley

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Jenkins test please

@pdudits
Copy link
Contributor

left a comment

Copyright year on line 40 needs updating

@pdudits pdudits added the Awaiting CLA label Jun 4, 2019

@pdudits

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

@johnmanko, please check our contribution guide, and fill out the CLA.. Update: not needed for change this small.

Thanks for your contribution!

@pdudits pdudits removed the Awaiting CLA label Jun 4, 2019

@pdudits
pdudits approved these changes Jun 4, 2019

@pdudits pdudits merged commit a33d96a into payara:master Jun 4, 2019

1 check passed

Payara Quick Build and Test Quick build and test passed!
Details

@Pandrex247 Pandrex247 changed the title Fixed typo in path. PAYARA-3918 Fixed typo in path. Jun 12, 2019

@arjantijms arjantijms added this to the 5.193 milestone Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.