Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3821 Add asadmin command to reset AMX metrics #4020

Merged
merged 30 commits into from Jun 10, 2019

Conversation

@AlanRoth
Copy link
Contributor

commented Jun 7, 2019

The feature has been requested by Rakuten to turn all monitoring items to OFF once, and then set it back to the previous value on the modules the user is watching to perform a 'reset'

The new command

restart-monitoring

Parameters

--target 
--verbose or -v

The target parameter specifies which config to reset the monitoring levels for.

AlanRoth added 12 commits Apr 29, 2019

@AlanRoth AlanRoth requested review from Cousjava, cubastanley, jbee and Pandrex247 Jun 7, 2019

@AlanRoth AlanRoth requested a review from jGauravGupta Jun 7, 2019

@jbee
Copy link
Contributor

left a comment

Looks good. Just some code style comments.

I see you made it work changing the configuration directly. Maybe you can provide some insight (e.g. in the class javadoc) why this is enough or how the reset becomes effective.

@Pandrex247
Copy link
Member

left a comment

Additional comment

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Looks good. Just some code style comments.

I see you made it work changing the configuration directly. Maybe you can provide some insight (e.g. in the class javadoc) why this is enough or how the reset becomes effective.

I'm going to have to find out more about it; my knowledge on how changing the config directly works is limited

@AlanRoth AlanRoth requested review from Pandrex247 and jbee Jun 7, 2019

@AlanRoth AlanRoth removed the DO NOT MERGE label Jun 7, 2019

AlanRoth added 3 commits Jun 7, 2019
@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Jenkins test please

@AlanRoth AlanRoth requested a review from Pandrex247 Jun 7, 2019

AlanRoth added 3 commits Jun 7, 2019
@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Jenkins test please

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Jenkins test please

@AlanRoth

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Jenkins test please

@AlanRoth AlanRoth merged commit 535c8c9 into payara:master Jun 10, 2019

58 of 59 checks passed

security/snyk - appserver/ant-tasks/pom.xml (payara-ci) 4 new vulnerable dependency paths
Details
Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
vlumi added a commit to vlumi/Payara that referenced this pull request Jun 11, 2019
Merge pull request payara#4020 from AlanRoth/PAYARA-3821
PAYARA-3821 Add asadmin command to reset AMX metrics

@arjantijms arjantijms added this to the 5.193 milestone Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.