Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3797 flush-connection-pool is now executed against all instances #4031

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@Cousjava
Copy link
Member

commented Jun 10, 2019

No description provided.

Cousjava added 2 commits Jun 10, 2019
PAYARA-3797 JDBC Flush will now execute against all known instances
flush-connection-pool command now sends a command to all known instances
to tell them to flush the connection pool

@Cousjava Cousjava added this to the 5.193 milestone Jun 10, 2019

@Cousjava Cousjava requested a review from fturizo Jun 10, 2019

@Cousjava Cousjava changed the title Payara 3797 jdbc flush instances PAYARA-3797 flush-connection-pool is now executed against all instances Jun 10, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Jenkins test please


@Param(name = "pool_name", primary = true)
@Param(name = "poolName")

This comment has been minimized.

Copy link
@Pandrex247

Pandrex247 Jun 11, 2019

Member

What's the reasoning behind not making this the primary param?

This comment has been minimized.

Copy link
@Cousjava

Cousjava Jun 11, 2019

Author Member

Because then it doesn't work when RemoteCLICommand tries to call it as it sends a ParameterMap of key-value pairs, a lone value is not accepted.

@Cousjava Cousjava force-pushed the Cousjava:PAYARA-3797-jdbc-flush-instances branch from 43d7839 to 0e87040 Jun 12, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Jenkins test please

@Cousjava Cousjava requested review from Pandrex247 and AlanRoth Jun 17, 2019

@Cousjava Cousjava merged commit 237036d into payara:master Jun 17, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
AlanRoth pushed a commit to AlanRoth/Payara that referenced this pull request Aug 13, 2019
Add legal info to all source and distribution jars (payara#4031)
* Add legal info: NOTICE.md and LICENSE.md
Signed-off-by: Jan Supol <jan.supol@oracle.com>
Cousjava added a commit to Cousjava/Payara that referenced this pull request Aug 21, 2019
Merge pull request payara#4031 from Cousjava/PAYARA-3797-jdbc-flush-i…
…nstances

PAYARA-3797 flush-connection-pool is now executed against all instances
Cousjava added a commit to Cousjava/Payara that referenced this pull request Aug 21, 2019
Merged in Cousjath/payara/PAYARA-3793-maint5191 (pull request payara#678
)

Merge pull request payara#4031 from Cousjava/PAYARA-3797-jdbc-flush-instances

Approved-by: Patrik Duditš <patrik.dudits@payara.fish>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.