Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3939 Remove Google Guava #4118

Merged
merged 6 commits into from Aug 8, 2019

Conversation

@Cousjava
Copy link
Member

commented Aug 1, 2019

Versions post-19.0 rely on JSR 305 which is not published by Oracle and can't be used by us. The functionality that Payara uses from Guava is available elsewhere in Payara or the standard Java library.

@Cousjava Cousjava added this to the 5.193 milestone Aug 1, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

This is an alternative to #4114

@Cousjava Cousjava force-pushed the Cousjava:PAYARA-3939-remove-guava branch from 9690a67 to f1579fa Aug 1, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Jenkins test please

@pdudits
pdudits approved these changes Aug 1, 2019
@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Jenkins test please

@Cousjava Cousjava force-pushed the Cousjava:PAYARA-3939-remove-guava branch from 44a05cb to f15aac8 Aug 2, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Jenkins test please

@jbee
jbee approved these changes Aug 2, 2019
Copy link
Contributor

left a comment

Really nice work @Cousjava

I made quite a number of remarks to improve code style but I don't think any of them is critical. We could merge it as is.

}
});
List<Class<Notifier>> notifierClassList = monitoringConfig.getNotifierList().stream().map((input) -> {
return resolveNotifierClass(input);

This comment has been minimized.

Copy link
@jbee

jbee Aug 2, 2019

Contributor

could just be input -> resolveNotifierClass(input); without the curly and round braces or even this::resolveNotifierClass (or even GetJMXMonitoringConfiguration::resolveNotifierClass).

}
});
List<Class<Notifier>> notifierClassList = configuration.getNotifierList().stream().map((input) -> {
return resolveNotifierClass(input);

This comment has been minimized.

Copy link
@jbee

jbee Aug 2, 2019

Contributor

And again (see above)

}
});
List<Class<NotifierConfiguration>> notifierConfigurationClassList = configuration.getNotifierConfigurationList().stream().map((input) -> {
return resolveNotifierConfigurationClass(input);

This comment has been minimized.

Copy link
@jbee

jbee Aug 2, 2019

Contributor

And again...

}
});
List<Class<Notifier>> notifierClassList = configuration.getNotifierList().stream().map((input) -> {
return resolveNotifierClass(input);

This comment has been minimized.

Copy link
@jbee

jbee Aug 2, 2019

Contributor

Again.

@Pandrex247
Copy link
Member

left a comment

Just one minor comment.

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Jenkins test please

@Cousjava Cousjava force-pushed the Cousjava:PAYARA-3939-remove-guava branch from 7b208fe to 2e046d5 Aug 2, 2019

@Cousjava

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Jenkins test please

@Pandrex247 Pandrex247 merged commit b10d932 into payara:master Aug 8, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.