Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA 3792 asadmin print certificate #4129

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@dmatej
Copy link
Contributor

commented Aug 5, 2019

  • prints informations about a certificate saved in a file
  • supported file types: der, pem, p12, jks, jceks
  • if using additional provider, it's jar must be in payara5/glassfish/lib/asadmin/ directory (f.e. BC)
@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Jenkins test please

@dmatej dmatej requested review from arjantijms, jbee and Pandrex247 Aug 6, 2019

@dmatej dmatej self-assigned this Aug 6, 2019

@jbee
jbee approved these changes Aug 6, 2019
Copy link
Contributor

left a comment

Some minor suggestions.
(Edit: Don't know enough about security as domain to make a proper review domain wise)

@dmatej dmatej force-pushed the dmatej:PAYARA-3792-asadmin-print-certificate branch from 7151f58 to 9594ebb Aug 6, 2019

@dmatej dmatej marked this pull request as ready for review Aug 6, 2019

@jbee
jbee approved these changes Aug 6, 2019
@Pandrex247
Copy link
Member

left a comment

Will give it a test in a bit, but just commenting on this bit first

@dmatej dmatej force-pushed the dmatej:PAYARA-3792-asadmin-print-certificate branch from 9594ebb to be8b6f8 Aug 6, 2019

@Pandrex247

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Not sure if I'm being silly, but this doesn't seem to have any auto-generated help?
asadmin print-certificate --help gives Cannot find man page for command: print-certificate

Is this because it's a CLI command rather than an Admin command?

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Then I am silly too :-/
I found more commands with this problem, but I don't know how it is processed.

@Pandrex247
Copy link
Member

left a comment

Aside from that I still think it should be a primary parameter, seems good :)

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Ok, finally I will mark it as primary, because it is "standard" and I hope users use certificate files more often than keystores, because then it is incomfortable as the primary argument must be the last ... (that was always pain).

PAYARA-3792 PrintCertificateCommand
- prints informations about a certificate saved in a file
- supported file types: der, pem, p12, jks, jceks
- the DN can be used as the principal-name in role-mapping

@dmatej dmatej force-pushed the dmatej:PAYARA-3792-asadmin-print-certificate branch from be8b6f8 to 6181fad Aug 7, 2019

@dmatej

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Jenkins test please

@dmatej dmatej merged commit 8abae8d into payara:master Aug 7, 2019

59 checks passed

Payara Quick Build and Test Quick build and test passed!
Details
security/snyk - api/payara-api/pom.xml (payara-ci) No new issues
Details
security/snyk - api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/admingui/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ant-tasks/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/appclient/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/batch/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/common/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/concurrent/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/connectors/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/core/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ejb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/extras/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/featuresets/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/ha/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/installer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/javaee-api/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jdbc/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/jms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/load-balancer/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/orb/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/payara-appserver-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/persistence/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/registration/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/security/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/transaction/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/web/pom.xml (payara-ci) No new issues
Details
security/snyk - appserver/webservices/pom.xml (payara-ci) No new issues
Details
security/snyk - copyright/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/admin/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/cluster/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/common/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/core/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/deployment/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/diagnostics/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/distributions/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/flashlight/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/grizzly/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/hk2/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/osgi-platforms/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/packager/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/payara-modules/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources-l10n/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/resources/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/security/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/test-utils/pom.xml (payara-ci) No new issues
Details
security/snyk - nucleus/tests/pom.xml (payara-ci) No new issues
Details
security/snyk - pom.xml (payara-ci) No new issues
Details

@dmatej dmatej deleted the dmatej:PAYARA-3792-asadmin-print-certificate branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.